WIP: Support Scala 2.13.0-RC2 #1479
Conversation
| "org.typelevel" %%% "cats-laws" % "2.0.0-M2" % "test", | ||
| "org.typelevel" %%% "cats-effect" % "2.0.0-M2", | ||
| "org.typelevel" %%% "cats-effect-laws" % "2.0.0-M2" % "test", | ||
| "org.scalacheck" %%% "scalacheck" % "1.14.0" % "test", |
There was a problem hiding this comment.
If we're on cats-laws-2.x and cats-effect-laws-2.x, we should be on scalacheck-1.14.0.
build.sbt
Outdated
| @@ -73,7 +66,7 @@ lazy val commonSettings = Seq( | |||
| implicit val contextShiftIO: ContextShift[IO] = IO.contextShift(global) | |||
| implicit val timerIO: Timer[IO] = IO.timer(global) | |||
| """, | |||
| doctestTestFramework := DoctestTestFramework.ScalaTest, | |||
| doctestTestFramework := DoctestTestFramework.ScalaCheck, | |||
There was a problem hiding this comment.
Working around sbt-doctest/sbt-doctest#130
|
Blocked on scalatest/scalatestplus-testng#3. We should consider porting those tests to reduce test dependency liability. |
|
Nope, easier said than done: it (appropriately) uses the reactive-streams-tck, which uses testng. |
|
Also blocked on scodec/scodec-bits#118. |
|
I was hoping to get #1478 in first given the ScalaTest changes. WDYT? |
|
That looks reasonable, and this is blocked on testng, so 👍*2. |
|
@rossabaker I updated this and fixed a few test issues introduced by the new test suite (unrelated to this PR). |
|
What is the version strategy going to be for this? fs2 doesn't publish laws (I don't think?), so it doesn't have to be major. But cats-effect-2.x will not be binary compatible in 2.11, and if the |
|
Argh, good catch. Maybe 1.1? |
|
I'm going to merge this to series/1.0 at least and then figure out where to go from there. |
No description provided.