-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lyceum:0.1.0 #1408
lyceum:0.1.0 #1408
Conversation
[no-stop] One of the tests is running for about 3 hours now. It is neither failing nor completing... unsure of what to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion about fonts, but if you prefer to keep Linux Libertine, it can be merged as is.
page-margin: (inside: 30mm, rest: 25mm), | ||
page-binding: left, | ||
page-fill: color.hsl(45deg, 15%, 85%), // ivory | ||
text-font: ("EB Garamond", "Linux Libertine"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux Libertine is no longer the default font in Typst because the Libertinus Serif fork is better maintained, maybe you want to change that here too?
text-font: ("EB Garamond", "Linux Libertine"), | |
text-font: ("EB Garamond", "Libertinus Serif"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely I'll change there too. Sorry to miss that one instance / Thanks for the diagnostic and suggestion, which I accept.
I've never had this sort of (pull-request's commit amidst comments) before... not sure how's the best way to proceed to accept it, but since I want such a commit on my side (as to tag it properly), I'll proceed by re-committing from my side, which has been automatically updating the PR. This time, it looks like it will go through without errors/warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes.
If my "suggested change" solved the whole problem, you could just have clicked "commit suggestion" and both of us would have been credited for it. In that case, because there were more occurrences of it to fix, doing it manually was the correct way to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @elegaanz !
I am submitting
Description: Lyceum is a simple academic book template that is in it's infancy. It may contain bugs and lack features.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE