Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lyceum:0.1.0 #1408

Merged
merged 5 commits into from
Dec 11, 2024
Merged

lyceum:0.1.0 #1408

merged 5 commits into from
Dec 11, 2024

Conversation

cnaak
Copy link
Contributor

@cnaak cnaak commented Dec 8, 2024

I am submitting

  • a new package
  • an update for a package

Description: Lyceum is a simple academic book template that is in it's infancy. It may contain bugs and lack features.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot added the new A new package submission. label Dec 8, 2024
@cnaak
Copy link
Contributor Author

cnaak commented Dec 9, 2024

[no-stop] One of the tests is running for about 3 hours now. It is neither failing nor completing... unsure of what to do.

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion about fonts, but if you prefer to keep Linux Libertine, it can be merged as is.

page-margin: (inside: 30mm, rest: 25mm),
page-binding: left,
page-fill: color.hsl(45deg, 15%, 85%), // ivory
text-font: ("EB Garamond", "Linux Libertine"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux Libertine is no longer the default font in Typst because the Libertinus Serif fork is better maintained, maybe you want to change that here too?

Suggested change
text-font: ("EB Garamond", "Linux Libertine"),
text-font: ("EB Garamond", "Libertinus Serif"),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely I'll change there too. Sorry to miss that one instance / Thanks for the diagnostic and suggestion, which I accept.

I've never had this sort of (pull-request's commit amidst comments) before... not sure how's the best way to proceed to accept it, but since I want such a commit on my side (as to tag it properly), I'll proceed by re-committing from my side, which has been automatically updating the PR. This time, it looks like it will go through without errors/warnings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes.
If my "suggested change" solved the whole problem, you could just have clicked "commit suggestion" and both of us would have been credited for it. In that case, because there were more occurrences of it to fix, doing it manually was the correct way to do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elegaanz !

@elegaanz elegaanz merged commit 222b9e3 into typst:main Dec 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants