Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncku-later:0.1.0 #1557

Merged
merged 12 commits into from
Jan 15, 2025
Merged

ncku-later:0.1.0 #1557

merged 12 commits into from
Jan 15, 2025

Conversation

Haouo
Copy link
Contributor

@Haouo Haouo commented Jan 12, 2025

I am submitting

  • a new package
  • an update for a package

Description: This is a template for master thesis or doctoral dissertation writing in National Cheng Kung University in Taiwan (not officially released).

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot added the new A new package submission. label Jan 12, 2025
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, but you probably want to update the year in the license file.

@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2024 CHUN-HAO CHANG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to have "2024-2025" or "2025" here instead of just "2024".

Copy link
Contributor Author

@Haouo Haouo Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! I will fix this very soon.

Furthermore, I want to modify the contents of the template to make it more like a "real" thesis writing example. The contents in the template now are just lots of meaningless words. I will let you know after I finish this.

Thanks for your reviewing! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elegaanz I have completed the work! You can review the changed part :) Thanks!

@Haouo Haouo requested a review from elegaanz January 15, 2025 08:12
@Haouo Haouo marked this pull request as ready for review January 15, 2025 08:12
@elegaanz
Copy link
Member

Thanks!

@elegaanz elegaanz merged commit ac21692 into typst:main Jan 15, 2025
2 checks passed
@Haouo
Copy link
Contributor Author

Haouo commented Jan 15, 2025

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants