-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modern-cornell-notebooks:0.2.0 #1570
Conversation
A Cornell style template based on the xyznote, with a restructured code format.
I just "sync" the fork and found this PR disappear... |
@@ -0,0 +1,138 @@ | |||
#import "../lib/lib.typ": * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use the package import here:
#import "../lib/lib.typ": * | |
#import "@preview/modern-cornell-notebooks:0.2.0": * |
version = "0.2.0" | ||
entrypoint = "template/cornell.typ" | ||
license = "MIT" | ||
description = "A Typst template for creating notebooks with cornell style." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"A typst template" is redundant:
description = "A Typst template for creating notebooks with cornell style." | |
description = "Notebooks with Cornell style." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this would be more correctly phrased as "Notebooks in the Cornell style", but I'm no English expert, so if it sounds bad to you feel free to ignore me.
[package] | ||
name = "modern-cornell-notebooks" | ||
version = "0.2.0" | ||
entrypoint = "template/cornell.typ" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should point to lib/lib.typ
instead (or at least to a file that is not part of your template).
entrypoint = "template/cornell.typ" | |
entrypoint = "lib/lib.typ" |
Hello. I would like to not leave this PR rotting for too long, so I would like to know if you had (or will have soon) time to fix the issues mentioned above? If not I will close the PR for now, but you can open a new one the day you are ready. |
As said above, I'm closing this PR for now. Feel free to open a new one once you have fixed the issues that were previously reported. |
I am submitting
Description:A Cornell style template based on the xyznote, with a restructured code format.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE