Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modern-cornell-notebooks:0.2.0 #1570

Closed
wants to merge 4 commits into from
Closed

modern-cornell-notebooks:0.2.0 #1570

wants to merge 4 commits into from

Conversation

aFei-CQUT
Copy link
Contributor

I am submitting

  • a new package
  • an update for a package

Description:A Cornell style template based on the xyznote, with a restructured code format.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Sorry, something went wrong.

@typst-package-check typst-package-check bot added the new A new package submission. label Jan 14, 2025
@aFei-CQUT
Copy link
Contributor Author

I just "sync" the fork and found this PR disappear...

@@ -0,0 +1,138 @@
#import "../lib/lib.typ": *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use the package import here:

Suggested change
#import "../lib/lib.typ": *
#import "@preview/modern-cornell-notebooks:0.2.0": *

version = "0.2.0"
entrypoint = "template/cornell.typ"
license = "MIT"
description = "A Typst template for creating notebooks with cornell style."
Copy link
Member

@elegaanz elegaanz Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"A typst template" is redundant:

Suggested change
description = "A Typst template for creating notebooks with cornell style."
description = "Notebooks with Cornell style."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this would be more correctly phrased as "Notebooks in the Cornell style", but I'm no English expert, so if it sounds bad to you feel free to ignore me.

[package]
name = "modern-cornell-notebooks"
version = "0.2.0"
entrypoint = "template/cornell.typ"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to lib/lib.typ instead (or at least to a file that is not part of your template).

Suggested change
entrypoint = "template/cornell.typ"
entrypoint = "lib/lib.typ"

@elegaanz
Copy link
Member

Hello. I would like to not leave this PR rotting for too long, so I would like to know if you had (or will have soon) time to fix the issues mentioned above? If not I will close the PR for now, but you can open a new one the day you are ready.

@elegaanz
Copy link
Member

As said above, I'm closing this PR for now. Feel free to open a new one once you have fixed the issues that were previously reported.

@elegaanz elegaanz closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants