-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CH4typ:0.0.1 #1572
base: main
Are you sure you want to change the base?
CH4typ:0.0.1 #1572
Conversation
This is the first time I created a packet. I may not cope with everything right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for the submission. Here are a few things to change before it can be merged, but your package generally looks good.
license = "MIT" | ||
entrypoint = "lib.typ" | ||
authors = ["β-吲哚基丙氨酸"] | ||
description = "an alternative for chem-par packet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion the description you wrote in your README is clearer to explain the purpose of the package, I would suggest copying it here.
description = "an alternative for chem-par packet" | |
description = "Typeset chemical formulas, both with inorganic and organic chemistry notation." |
@@ -0,0 +1,7 @@ | |||
[package] | |||
name = "CH4typ" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to to use lower-kebab-case for your package name. The current name would become ch-4-typ
, but (if I remember my chemistry class correctly) that would ruin the joke in the name. Maybe you can change the name entirely if you are not satisfied with that.
I am submitting
Description: Explain what the package does and why it's useful.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE