-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ustc-proposal:0.0.1 #1710
base: main
Are you sure you want to change the base?
ustc-proposal:0.0.1 #1710
Conversation
7fbfaf8
to
6df28eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your template contains too many files that are not directly related to the project in my opinion. I understand that these files may be useful for power users, but I think for someone who doesn't use all these tools they will just feel like too much (especially in the web app where you can't really use any of that). Since I can see that you are using Nix, I would recommend using the flake template features to provide a "full" template (or alternatively the GitHub "repository template" feature), and to keep the Typst template as minimal as possible.
Also, I'm not sure what the purpose of the package is, but the name may too descriptive/generic. Please make sure to conform to the naming guidelines.
packages/preview/ustc-proposal/0.0.1/.github/workflows/main.yml
Outdated
Show resolved
Hide resolved
6df28eb
to
f9754d5
Compare
@Robotechnic You released diagraph:0.3.0, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
f9754d5
to
ae23de0
Compare
6645057
to
b85e802
Compare
Hello. With regards to the package name, I would like to know if this is intended to be an official template or not? Also, the compiler reports an issue when building your template, can you please fix it? |
it waits typst 0.13.0 Offical docx template doesn't have English name. |
b85e802
to
fe843f5
Compare
Sorry to ask for changes again, but can you fix the deprecation warnings too? Regarding the name, I was more asking whether this package is considered official too, not what the name of the official Word template is. But I assume it is not then. Can you please rename the package to something more distinctive? |
fe843f5
to
a0a11f1
Compare
I am submitting
Description: Explain what the package does and why it's useful.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE