lsattr: fix potential 32-bit integer overflow warning

This can't happen in practice due to MAXPATHNAMELEN constraints, but gcc is too dumb to know that. Signed-off-by: Theodore Ts'o <[email protected]>
tytso · Feb 26, 2025 · a0ae27b · a0ae27b
1 parent 181d1c2
commit a0ae27b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/misc/lsattr.c b/misc/lsattr.c
@@ -141,9 +141,13 @@ static int lsattr_dir_proc (const char * dir_name, struct dirent * de,
 {
 	STRUCT_STAT	st;
 	char *path;
-	int dir_len = strlen(dir_name);
+	size_t dir_len = strlen(dir_name), name_len = strlen (de->d_name);
 
-	path = malloc(dir_len + strlen (de->d_name) + 2);
+	if ((dir_len > 1024 * 1024 * 1024) ||
+	    (name_len > 1024 * 1024 * 1024))
+		return -1;
+
+	path = malloc(dir_len + name_len + 2);
 	if (!path) {
 		fputs(_("Couldn't allocate path variable in lsattr_dir_proc\n"),
 			stderr);