minor things #74
Merged
minor things #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2022 07:55
Signed-off-by: Barret Rhoden <[email protected]>
This lets you get debug info from cpud's child processes. The info will be outputted in the cpu client's stream. Signed-off-by: Barret Rhoden <[email protected]>
rminnich
approved these changes
Mar 11, 2022
added 2 commits
March 15, 2022 11:57
It was almost equivalent to cmds/cpu/doc.go, execpt the 'cpu' version had changes from commit b07df11 ("cpu: alphabetize options, update doc.go"). Signed-off-by: Barret Rhoden <[email protected]>
The return code for bash is the return code for the last command in bash. If cpu HOST bash then ran a command that failed, cpud would think that the shell failed. It wouldn't propagate the exact error code either. cpu on the client side would get an exit code of 1. e.g. $ cpu HOST sh sh-5.1# ^C sh-5.1# exit 2022/03/10 08:55:28 CPUD(as remote):exit status 130 2022/03/10 08:55:28 SSH error Process exited with status 1 $ echo $? 1 Although it might be nice to propagate the error code (e.g. 130) to cpu, just ignoring the error is probably easier for users to handle. sshd seems to have some error propagation. If you ctl-c, then ctl-d, ssh returns 0. If you ls no-such-file, ssh returns 1, not 2 (which is what bash returns). Alternatively we could just propagate the '1', like ssh does, and not spit out the error messages. Signed-off-by: Barret Rhoden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feel free to drop any or all of these.