Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

Update sfx_service.rb #2074

Merged
4 commits merged into from
Oct 20, 2020
Merged

Update sfx_service.rb #2074

4 commits merged into from
Oct 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2020

Add local blacklight target to list of exclusions.

Context

Related to #2073

What's New

Added blacklight SFX target to local exclusion list in sfx_service.rb

Add local blacklight target to list of exclusions.
@ghost ghost requested a review from murny October 6, 2020 12:32
murny
murny previously approved these changes Oct 6, 2020
Copy link
Contributor

@murny murny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (might need to rebase as there is a merge conflict with CHANGELOG.md)

@ghost
Copy link
Author

ghost commented Oct 7, 2020

@murny Hi Shane - sorry to bug you with this. Can you see why the travis checks would be failing? I don't think I changed enough to have caused a problem... Thanks!

@murny
Copy link
Contributor

murny commented Oct 7, 2020

Seems like same issues Tricia was having last week.

@pgwillia was there anything you found we can do to get around these travis failures?

@pgwillia
Copy link
Member

pgwillia commented Oct 7, 2020

Failures:

  1) Catalog Search User visits an SFX item result

     Failure/Error: visit 'catalog/954921333008'

     Net::ReadTimeout:

       Net::ReadTimeout

     # ./spec/features/catalog_search_spec.rb:22:in `block (3 levels) in <top (required)>'

     # ./spec/features/catalog_search_spec.rb:21:in `block (2 levels) in <top (required)>'

  2) Item has proper holding table Sfx item has proper holding table

     Failure/Error: visit '/catalog/954921333007'

     Net::ReadTimeout:

       Net::ReadTimeout

     # ./spec/features/item_holding_table_spec.rb:21:in `block (3 levels) in <top (required)>'

     # ./spec/features/item_holding_table_spec.rb:20:in `block (2 levels) in <top (required)>'

  3) Link to ill Sfx item has link to ill

     Failure/Error: visit '/catalog/954921333007'

     Net::ReadTimeout:

       Net::ReadTimeout

     # ./spec/features/item_ill_link_spec.rb:4:in `block (3 levels) in <top (required)>'

     # ./spec/features/item_ill_link_spec.rb:3:in `block (2 levels) in <top (required)>

This is happening for every PR right now. It started last week. I'm not sure why it suddenly has read time outs for SFX. They should be coming from VCR.

@pgwillia
Copy link
Member

pgwillia commented Oct 7, 2020

Seems like same issues Tricia was having last week.

@pgwillia was there anything you found we can do to get around these travis failures?

We could either turn off those tests (ick) or not make the checks mandatory (ick, ick).

@ghost
Copy link
Author

ghost commented Oct 7, 2020

Hm, OK, thanks. Not sure what the best thing would be there...

@pgwillia
Copy link
Member

@ConnorSheremeta was able to fix the failing tests. @redlibrarian you can rebase or merge.

@ghost ghost merged commit 2872017 into master Oct 20, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants