-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
Add local blacklight target to list of exclusions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 (might need to rebase as there is a merge conflict with CHANGELOG.md)
@murny Hi Shane - sorry to bug you with this. Can you see why the travis checks would be failing? I don't think I changed enough to have caused a problem... Thanks! |
Seems like same issues Tricia was having last week. @pgwillia was there anything you found we can do to get around these travis failures? |
This is happening for every PR right now. It started last week. I'm not sure why it suddenly has read time outs for SFX. They should be coming from VCR. |
We could either turn off those tests (ick) or not make the checks mandatory (ick, ick). |
Hm, OK, thanks. Not sure what the best thing would be there... |
@ConnorSheremeta was able to fix the failing tests. @redlibrarian you can rebase or merge. |
Add local blacklight target to list of exclusions.
Context
Related to #2073
What's New
Added blacklight SFX target to local exclusion list in sfx_service.rb