Fixing error message issue #618
Conversation
Error messages were not working because this application file had references to cms files. I have removed these. Also removed the dark mode and language selectors as we don't need these in the application layout.
formatting changes
formatting changes
formatting changes.
| <% else %> | ||
| Library | ||
| <% end %> | ||
| U of A Library |
There was a problem hiding this comment.
Curious why you removed the content for(:title)/cms_page.label stuff? This seemed useful?
There was a problem hiding this comment.
As far as I can tell the cms calls were creating the error so I decided to just remove them.
| <!-- Google Tag Manager --> | ||
| <script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start': | ||
| new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0], | ||
| j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src= | ||
| 'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); | ||
| })(window,document,'script','dataLayer','GTM-MX43PRW2');</script> | ||
| <!-- End Google Tag Manager --> | ||
| <%= stylesheet_link_tag comfy_cms_render_css_path(@cms_site.id, @cms_layout.identifier) %> |
There was a problem hiding this comment.
You could just wrap this in a check? If we have a @cms_site then we are in the CMS, so we want the stylesheets/js from the CMS. Otherwise we are not in the CMS, so don't include the css/js from the CMS? So it works for both worlds?
There was a problem hiding this comment.
We could do - but as far as I can tell the only thing that uses the application layout are these error pages. This seemed like the quickest and easiest way to get everything working :)
|
Thanks for approving @murny let me know if you want to make the changes you suggested above. Otherwise, I'm hoping we can cut a release next week when Neil is back from folk fest. |
|
Nothing blocking on my side. So all is good 👍. Just some suggestions to try to have this layout work in both CMS/non CMS world (but probably everything in CMS world is using the basic layout one) |
Error messages were not working because this application file had references to cms files. I have removed these. Also removed the dark mode and language selectors as we don't need these in the application layout.
In addition, I have changed the mark-up for the error pages so they display nicer.