Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cs310_2022w2_round2 #424

Merged
merged 74 commits into from
Oct 31, 2022
Merged

cs310_2022w2_round2 #424

merged 74 commits into from
Oct 31, 2022

Conversation

rtholmes
Copy link
Contributor

@rtholmes rtholmes commented Oct 7, 2022

This PR fixed some problems observed at runtime in 310 this term, but also spent (too much) time improving the console output on the deployed host for monitoring classy/autotest and ensuring it was behaving as expected. These changes make docker compose logs --tail 10000 -f autotest portal much more useful in production.

Done

Before Merging

  • Update 310 plugin to use new @common paths

@rtholmes rtholmes self-assigned this Oct 7, 2022
@coveralls
Copy link

coveralls commented Oct 7, 2022

Pull Request Test Coverage Report for Build 46a506c3-bfe1-4969-a1ce-49ec9d80e934

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 223 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+3.002%) to 89.453%

Files with Coverage Reduction New Missed Lines %
src/controllers/DeliverablesController.ts 1 96.08%
src/controllers/AuthController.ts 2 96.43%
src/controllers/TeamController.ts 3 97.14%
src/server/common/AutoTestRoutes.ts 12 89.57%
src/controllers/AdminController.ts 15 91.79%
src/controllers/ResultsController.ts 17 87.38%
src/server/common/GeneralRoutes.ts 18 90.64%
src/controllers/GitHubActions.ts 33 88.75%
src/controllers/DatabaseController.ts 51 82.83%
src/server/common/AdminRoutes.ts 71 83.16%
Totals Coverage Status
Change from base Build 0119176f-a88b-4f51-b908-b56eacc22f36: 3.002%
Covered Lines: 3620
Relevant Lines: 3977

💛 - Coveralls

@rtholmes rtholmes added this to the v2.5 milestone Oct 31, 2022
@rtholmes rtholmes merged commit c683817 into master Oct 31, 2022
@rtholmes rtholmes deleted the cs310_2022w2_round2 branch February 22, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config booleans are always true
2 participants