Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incomplete installation instructions for 10.5 #407

Open
wants to merge 3 commits into
base: xdmod10.5
Choose a base branch
from

Conversation

connersaeli
Copy link
Collaborator

@connersaeli connersaeli commented Jan 13, 2025

The installation instructions to enable the PowerTools repository required for the python summarization tools were missing. This PR adds the command to enable the PowerTools repository. Corresponding documentation PR's here:

Description

Motivation and Context

Tests performed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@connersaeli connersaeli changed the title Updating incomplete installation instructions for 10.5 Update incomplete installation instructions for 10.5 Jan 13, 2025
jpwhite4
jpwhite4 previously approved these changes Jan 13, 2025

# dnf install epel-release

It also requires the PCP python libraries, which are included in Rocky 8.
# dnf config-manager --set-enabled powertools

An RPM package for Rocky 8 is [available for download](https://github.com/ubccr/supremm/releases/latest).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this link to https://github.com/ubccr/supremm/releases instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference? I see that the current one just points to the current release while the suggested link points to all releases. I don't understand what the issue is with the current link.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I would argue that it's better to point to the latest release when that line explicitly mentions the Rocky 8 RPM package. I won't be too stubborn about this though, let me know your thoughts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking if latest and page.summ_sw_version get out of sync from each other (e.g., as they were in the CentOS 7 instructions). Maybe it should link to https://github.com/ubccr/supremm/releases/tag/{{ page.summ_sw_version }}?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants