-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update incomplete installation instructions for 10.5 #407
base: xdmod10.5
Are you sure you want to change the base?
Update incomplete installation instructions for 10.5 #407
Conversation
docs/supremm-processing-install.md
Outdated
|
||
# dnf install epel-release | ||
|
||
It also requires the PCP python libraries, which are included in Rocky 8. | ||
# dnf config-manager --set-enabled powertools | ||
|
||
An RPM package for Rocky 8 is [available for download](https://github.com/ubccr/supremm/releases/latest). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this link to https://github.com/ubccr/supremm/releases instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference? I see that the current one just points to the current release while the suggested link points to all releases. I don't understand what the issue is with the current link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, I would argue that it's better to point to the latest release when that line explicitly mentions the Rocky 8 RPM package. I won't be too stubborn about this though, let me know your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking if latest
and page.summ_sw_version
get out of sync from each other (e.g., as they were in the CentOS 7 instructions). Maybe it should link to https://github.com/ubccr/supremm/releases/tag/{{ page.summ_sw_version }}
?
The installation instructions to enable the PowerTools repository required for the python summarization tools were missing. This PR adds the command to enable the PowerTools repository. Corresponding documentation PR's here:
Description
Motivation and Context
Tests performed
Types of changes
Checklist: