Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to save Regression Test UsageChart images #1973

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryanrath
Copy link
Contributor

@ryanrath ryanrath commented Feb 5, 2025

These changes add the ability to, by specifying a env variable, to instruct the UsageChart image export tests to save the actual images to the /tmp/ directory so that they can be compared to another set of images to determine why these tests may be failing.

These changes will also output a metadata file to be used in further determining potential similiarities in test failures.

Description

Motivation and Context

Tests performed

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@ryanrath ryanrath force-pushed the add-regression-image-compare-infra branch from 756c809 to 7d34c7a Compare February 10, 2025 16:04
@ryanrath ryanrath marked this pull request as ready for review February 10, 2025 16:06
@ryanrath ryanrath force-pushed the add-regression-image-compare-infra branch from 7d34c7a to c3eff6a Compare February 10, 2025 16:06
@ryanrath ryanrath changed the title Adding ability to save UsageChart images Adding ability to save Regression Test UsageChart images Feb 18, 2025
These changes add the ability to, by specifying a env variable, to
instruct the UsageChart image export tests to save the actual images to
the `/tmp/` directory so that they can be compared to another set of
images to determine why these tests may be failing.

These changes will also output a metadata file to be used in further
determining potential similiarities in test failures.
@ryanrath ryanrath force-pushed the add-regression-image-compare-infra branch from c3eff6a to b40dec3 Compare February 18, 2025 15:04
@ryanrath ryanrath added this to the 11.5.0 milestone Feb 18, 2025
@ryanrath ryanrath added autodoc:ignore Auto documentation ignore this PR qa / testing Updates/additions to tests Category:Infrastructure Internal infrastructure updates/changes labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodoc:ignore Auto documentation ignore this PR Category:Infrastructure Internal infrastructure updates/changes qa / testing Updates/additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant