removed normalized_avg_processors and created documentation on how to add it back #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on how to re add it.
|
When i was orginally removing normailzied_avg_processors i accidentally modified the shape of has_data_access.json which caused the component test to fail. After seeing that i went back in and used jq to fix the json to be in the shape that it is supposed to, Component Testing passes. |
eiffel777
approved these changes
Feb 19, 2025
aaronweeden
requested changes
Feb 19, 2025
There was a problem hiding this comment.
I think there should be a description at the top of this file explaining why the statistic was removed.
aaronweeden
requested changes
Feb 19, 2025
| @@ -0,0 +1,90 @@ | |||
| The Normalized Avg Processor statistic is available if you add the following JSON and SQL Files to the XDMoD project. | |||
There was a problem hiding this comment.
Suggested change
| The Normalized Avg Processor statistic is available if you add the following JSON and SQL Files to the XDMoD project. | |
| The "Job Size: Normalized" statistic can be restored if you modify/add the following JSON and SQL files to your installation of Open XDMoD. The files are located in `/etc/xdmod` unless you used a different prefix when installing Open XDMoD (e.g., `/opt/xdmod-{{ page.sw_version }}/etc`). |
Comment on lines
+3
to
+4
| 1. Add the follwing to: | ||
| - configuration/datawarehouse.d/ref/Job-Statistics.json |
There was a problem hiding this comment.
Suggested change
| 1. Add the follwing to: | |
| - configuration/datawarehouse.d/ref/Job-Statistics.json | |
| Add the following to `datawarehouse.d/ref/Jobs-statistics.json`: |
Comment on lines
+22
to
+23
| 2. Add the following to: | ||
| - configuration/datawarehouse.d/ref/Gateways-Statistics.json |
There was a problem hiding this comment.
Suggested change
| 2. Add the following to: | |
| - configuration/datawarehouse.d/ref/Gateways-Statistics.json | |
| 2. Add the following to `datawarehouse.d/ref/Gateways-statistics.json`: |
Comment on lines
+34
to
+35
| 3. Create a **jobs-norm-avg-proc-time.sql** in the following: | ||
| - configuration/datawarehouse.d/include/jobs-norm-avg-proc-time.sql |
There was a problem hiding this comment.
Suggested change
| 3. Create a **jobs-norm-avg-proc-time.sql** in the following: | |
| - configuration/datawarehouse.d/include/jobs-norm-avg-proc-time.sql | |
| 3. Create the file `datawarehouse.d/include/Jobs-norm-avg-proc-time.sql`: |
Comment on lines
+63
to
+64
| 4. create a **jobs-norm-avg-proc-agg.sql** at the follwing: | ||
| - configuration/datawarehouse.d/include/jobs-norm-avg-proc-agg.sql |
There was a problem hiding this comment.
Suggested change
| 4. create a **jobs-norm-avg-proc-agg.sql** at the follwing: | |
| - configuration/datawarehouse.d/include/jobs-norm-avg-proc-agg.sql | |
| 4. Create the file `datawarehouse.d/include/Jobs-norm-avg-proc-agg.sql`: |
| @@ -8,3 +8,4 @@ The Open XDMoD HOWTOs are "how to" documents on specific subjects. | |||
| - [Change Metric Explorer Colors](howto-colors.html) | |||
| - [Enable Node Utilization Statistics](howto-node-utilization.html) | |||
| - [Reconstruct Slurm Accounting Logs](howto-reconstruct-slurm.html) | |||
| - [Add Normalize Avg Processors](howto-normalized-avg-processors.html) | |||
There was a problem hiding this comment.
Suggested change
| - [Add Normalize Avg Processors](howto-normalized-avg-processors.html) | |
| - [Restore the "Job Size: Normalized" statistic](howto-normalized-avg-processors.html) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removed normalized_avg_processors from configuration/datawarehouse.d/ref/ gateways-statsitics.json and job-statistics.json, deleted jobs-norm-avg-proc-time.sql and jobs-norm-avg-proc-agg.sql from configuration/datawarehouse.d/include.
Then created howto-normalized-avg-processor.md on how to re add the statistic.
Motivation and Context
The statistic did not have much use and was a 100% correct because of the sql so it was removed with a documenation added to re add it if someone was interested in that statistic.
Tests performed
Re ran all the regression test on a aarch64 and x86_64 system.
Checklist: