-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwright and docker compose integration for Ciricle CI testing #1985
Open
rvtovar
wants to merge
83
commits into
ubccr:main
Choose a base branch
from
rvtovar:playwright_doc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes migrate our current UI test framework from webdriverio to playwright. The reasons for the migration include but are not limited to: - During testing Playwright proved to be more resilient to timining issues than webdriverio. This should mean less failures of CI builds due to timing issues which means less time dealt with timing issue failures during CI builds. - Playwright supports parallel test execution so CI builds end up taking significantly less time. The original ui tests in `tests/ui/*` have been removed as they are no longer needed.
Co-authored-by: Aaron Weeden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autodoc:ignore
Auto documentation ignore this PR
Category:Infrastructure
Internal infrastructure updates/changes
qa / testing
Updates/additions to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
merged playwright tests into a 11.5 verison branch of the app and then updated the circle CI to run the test succesfully
Motivation and Context
Playwright fixes a lot of problems with UI Testing and moves us towards a docker compose set up
Tests performed
Updated circle CI config file and make sure test ran and that the playwright test were sucessful.
Checklist: