This repository has been archived by the owner on May 4, 2021. It is now read-only.
Use layers digest for CacheID in FROM step #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krumstein
force-pushed
the
feature/hash-from
branch
from
36167be
to
c5f9855
Compare
krumstein
force-pushed
the
feature/hash-from
branch
from
c5f9855
to
39c3b18
Compare
|
|
|
I think the best approach should be using SHA256 hash of manifest content. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using layers digest for calculating cacheID allows to use cache between different image tags. This can be very useful if there's a lot of similar images with different tags, for example, in a CI/CD pipeline where each feature branch produces different image tag.