ci: Fix broken main #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$(shell pwd)` doesn't work on Windows as-is. Use MAKEFILE_LIST to get the path to the Makefile, and then work back to find the directory from that. This is cross-platform. Also make the Makefile always run the bash shell, so we it doesn't try to powershell anything. Lastly, make the cff, mockgen, staticcheck, and mdox targets relative to the directory rather than absolute. Their absolute paths aren't necessary; bin is added to the PATH so just their names can be used directly.
|
I don't think any of this was tested on Windows. If CI fails on Windows, we should drop Windows support to unblock CI and the other PRs until the relevant issues are fixed. |
|
Yeah, did. |
sywhang
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI on main is currently broken for several reasons:
All but the last issue has been fixed by this PR.
We're dropping Windows support for now.
Two follow-ups were created: #53, #54