-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade to Checker Framework 3.40.0 #895
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #895 +/- ##
=========================================
Coverage 86.95% 86.95%
Complexity 1953 1953
=========================================
Files 77 77
Lines 6315 6315
Branches 1222 1222
=========================================
Hits 5491 5491
Misses 420 420
Partials 404 404 ☔ View full report in Codecov by Sentry. |
/benchmark |
Main Branch:
With This PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find and really appreciate the extra test case! Hopefully upstream can fix this soon.
This fixes a regression where we were seeing a crash in CFG construction. Reported upstream as typetools/checker-framework#6396.