Add intersect util method for StringSet #4
Conversation
|
|
| } | ||
|
|
||
| // Add testItems to testSet | ||
| for _, item := range testItems { |
There was a problem hiding this comment.
use string set Add method
There was a problem hiding this comment.
I can do it but then tests will be different from previous ones.
| } | ||
|
|
||
| // Intersect the two stringSet | ||
| intersection := testSet.Intersect(testSet1) |
There was a problem hiding this comment.
Use test table and add more unit tests such as
- No intersection result
- Empty sets
- both set are purely different.
There was a problem hiding this comment.
Use table driven tests, rather than creating separate tests.
https://github.com/golang/go/wiki/TableDrivenTests
There was a problem hiding this comment.
cool stuff!
Thanks I understand what you meant now.
Tests unified in one according to TableDrivenTests.
|
I do not think we should add the func if there is no use case. |
That's fine. |
|
@axamon Update the commit message to be more meaningful. |
|
I added the intersect function for *StringSet types that is concurrency safe. |
Can you change commit name from "added intersect" to something "Add intersect util method for StringSet" As well as change commit message from "might be useful" -> relevant to the PR. |
|
@axamon Thank for the fixes, we do not have unit & integration test CI setup at open source yet. I will run the patch locally, if no errors then I will merge the PR. |
Intersect function for *StringSet types that is concurrent safe added.