Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial notebook for micromagneticdata based on DW pair conversion example #70

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

kzqureshi
Copy link
Contributor

No description provided.

@kzqureshi kzqureshi requested a review from lang-m April 29, 2024 13:35
@lang-m lang-m requested review from swapneelap and removed request for lang-m May 31, 2024 15:33
Copy link
Member

@swapneelap swapneelap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have following comments:

  1. Above cell [8]: It would be better to write indexing the Data object instead of indexing "over".
  2. Above cell [10]: Similarly, index the object, not index over the object.
  3. Above cell [12]: I think "call" is a keyword in programming, and typically, it has something to do with functions. Calling the drive sounds like the drive is a callable to me (?). I think it is better to write, "We can also observe the final magnetisation state of the time driver by indexing the last drive, i.e., time_drive[-1]"

Rest looks good to me.

@kzqureshi kzqureshi requested a review from swapneelap June 3, 2024 19:38
@lang-m
Copy link
Member

lang-m commented Jun 9, 2024

Failing pre-commits can be ignored (nothing is configured on this branch). We should either soon merge #72 or (again) disable pre-commit for this repository.

@lang-m lang-m linked an issue Jun 9, 2024 that may be closed by this pull request
5 tasks
@lang-m lang-m self-assigned this Jun 9, 2024
@lang-m lang-m requested review from samjrholt and removed request for swapneelap June 9, 2024 19:21
@lang-m lang-m changed the title modified notebook with extended Tutorial notebook for micromagneticdata based on DW pair conversion example Jun 9, 2024
@samjrholt samjrholt merged commit df1b84c into master Jun 11, 2024
0 of 4 checks passed
@samjrholt samjrholt deleted the micromagneticdata_dw-pair-conversion branch June 11, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create micromagneticdata tutorial notebook
4 participants