feat: task limit improvement #66

ariesgun · 2024-10-20T09:52:05Z

Resolves #64

src/utils/issue.ts

0x4007 · 2024-10-20T14:33:27Z

You also should post QA

ariesgun · 2024-10-20T15:01:02Z

You also should post QA

sorry, new here. what do you mean by "post QA"?

0x4007 · 2024-10-20T15:23:24Z

Prove that it works on your org. This would be a link to a github comment

src/utils/issue.ts

ariesgun · 2024-10-21T16:39:06Z

Prove that it works on your org. This would be a link to a github comment

Test Result:

https://github.com/ubiquity-ariesgun/command-start-stop/issues/9#issuecomment-2427166082

src/plugin.ts

0x4007 · 2024-10-22T08:10:24Z

Test Result:

ubiquity-ariesgun#9 (comment)

Currently looking into adjusting the display format:

Warning

You have reached your max task limit. Please close out some tasks before assigning new ones.

ubiquity-os-marketplace/command-start-stop - Task Limit Improvements #64

- ###### [ubiquity-os-marketplace/command-start-stop - Task Limit Improvements #64](https://www.github.com/ubiquity-os-marketplace/command-start-stop/issues/64)

src/handlers/shared/start.ts

ariesgun · 2024-10-26T14:11:00Z

QA:

https://github.com/ubiquity-ariesgun/command-start-stop/issues/12#issuecomment-2439593830

tests/main.test.ts

src/plugin.ts

0x4007 · 2024-10-27T22:49:00Z

Need to specifically handle 404

ariesgun · 2024-10-28T07:54:18Z

Need to specifically handle 404

Any specific action when is 404?
Right now it will log and write it as a comment in github in case of non-200

0x4007 · 2024-10-28T14:09:15Z

I wish we had a mechanism to detect if this breaks to respond quickly because that system may be changed without notice in the future. I suppose for now you should throw a specific and descriptive error if it 404.

A lot of work is being done on the devpool-directory backend so I anticipate that this file name will eventually be changed or removed so the faster we can diagnose this problem the better.

package.json

whilefoo

forgot to submit review :D

src/handlers/shared/start.ts

src/plugin.ts

0x4007 · 2024-10-31T14:27:15Z

Should be configurable
Repo
Org
Network

Also that's wild that I can't delete or hide your review comment

gentlementlegen · 2024-11-01T02:42:47Z

@0x4007 Why did you hide my comment (if that was you)?

0x4007 · 2024-11-01T18:38:25Z

Your review comment is the exact same content

ubiquity-os-beta · 2024-11-02T06:26:18Z

@ariesgun, this task has been idle for a while. Please provide an update.

gentlementlegen · 2024-11-02T06:29:47Z

@0x4007 maybe you are confused because I first posted my comment with the wrong account and then hid it to repost with my own? I can't seem to find twice the same comment from myself.

0x4007 · 2024-11-02T07:18:15Z

gentlementlegen · 2024-11-02T07:34:20Z

Yes that was with the wrong account, I hid that comment.

…mprovement

ariesgun · 2024-11-03T16:31:49Z

Made the issues search configurable: repo, org, or network.
Fixed the merge conflict.

Network:
https://github.com/ubiquity-ariesgun/command-start-stop/issues/12#issuecomment-2453487597

Org:
https://github.com/ubiquity-ariesgun/command-start-stop/issues/12#issuecomment-2453486116

Repo:
https://github.com/ubiquity-ariesgun/command-start-stop/issues/12#issuecomment-2453485977

gentlementlegen · 2024-11-04T12:55:12Z

src/plugin.ts

@@ -16,6 +53,7 @@ export async function startStopTask(inputs: PluginInputs, env: Env) {
    eventName: inputs.eventName,
    payload: inputs.eventPayload,
    config: inputs.settings,
+    organizations: [],


This should not be here but in the configuration.

I think the reasoning is that it's needed at multiple places so they just put it in the context

The spec states:

Only check assigned issues within the network, but this should be configurable to either be just within the repo, org, or network

Shouldn't this be configurable? And even if not, putting it in the config also allows to add defaults on decode which would ensure it is properly initialized and types as well.

Not sure. It mentions the scope is configurable: repo, org , or network.. Dont understand what you meant

maybe I'm missing something, but the config item assignedIssueScope can be set to repo, org or network, this configuration property gets filled based on assignedIssueScope when the plugin starts

yeah that's how it behaves.. Based on assignedIssueScope, it will fill in the organization accordingly.

gentlementlegen · 2024-11-04T12:55:30Z

src/utils/issue.ts

      .paginate(context.octokit.rest.search.issuesAndPullRequests, {
-        q: `org:${payload.repository.owner.login} assignee:${username} is:open is:issue`,
+        q: `${repoOrgQuery} assignee:${username} is:open is:issue`,


Since you use the organizations with a search, it is possible that the user has a private profile which will result in a 422 error when querying the search API. You need to provide a fallback for this.

There is already a function getAssignedIssuesFallback isnt it?

I could reproduce it, but now i am not sure what kind of fallback we can do here??

nvm, the function getAssignedIssuesFallback handled it gracefully.

When I tested with a user having a private profile, the run crashed on a 422 error. I will test again.

I changed the construct to 'await' so it will be able to catch 422 and trigger getAssignedIssuesFallback

src/types/plugin-input.ts

src/utils/issue.ts

src/plugin.ts

manifest.json

gentlementlegen · 2024-11-06T03:42:55Z

Last QA looks ok: Meniole#46

However when using network option to scan for PRs, I could go beyond the limit of one assigned issue: Meniole#47

@ariesgun What does network look for?

ariesgun · 2024-11-06T07:27:10Z

Last QA looks ok: Meniole#46

However when using network option to scan for PRs, I could go beyond the limit of one assigned issue: Meniole#47

@ariesgun What does network look for?

it is gonna look at devpool-issues.json and look for any assigned issues there

feat: task limit improvement

5497d7e

ariesgun marked this pull request as ready for review October 20, 2024 09:52

0x4007 requested changes Oct 20, 2024

View reviewed changes

src/utils/issue.ts Outdated Show resolved Hide resolved

0x4007 reviewed Oct 21, 2024

View reviewed changes

src/utils/issue.ts Outdated Show resolved Hide resolved

ariesgun requested a review from 0x4007 October 21, 2024 16:37

gentlementlegen reviewed Oct 21, 2024

View reviewed changes

src/plugin.ts Outdated Show resolved Hide resolved

gentlementlegen reviewed Oct 23, 2024

View reviewed changes

src/handlers/shared/start.ts Outdated Show resolved Hide resolved

gentlementlegen reviewed Oct 23, 2024

View reviewed changes

src/handlers/shared/start.ts Outdated Show resolved Hide resolved

0x4007 reviewed Oct 26, 2024

View reviewed changes

tests/main.test.ts Show resolved Hide resolved

src/plugin.ts Outdated Show resolved Hide resolved

0x4007 approved these changes Oct 28, 2024

View reviewed changes

gentlementlegen reviewed Oct 29, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

This comment has been minimized.

Sign in to view

whilefoo suggested changes Oct 29, 2024

View reviewed changes

src/handlers/shared/start.ts Outdated Show resolved Hide resolved

src/plugin.ts Outdated Show resolved Hide resolved

src/plugin.ts Outdated Show resolved Hide resolved

ariesgun and others added 7 commits November 3, 2024 16:41

fix: update mock handlers

0953019

fix: handle fetch error

2474312

fix: handle 404

d09f2d4

fix: revert change in package.json

8bf9f6f

fix: update yarn.lock

910ebf0

fix: cleanup

239d26e

feat: make issues and PRs search configurable

32e9280

ariesgun force-pushed the task-limit-improvement branch from 316467b to 32e9280 Compare November 3, 2024 15:41

Merge remote-tracking branch 'original/development' into task-limit-i…

d10db4a

…mprovement

fix: updated yarn.lock

0a6bd74

gentlementlegen requested review from whilefoo, Keyrxng and gentlementlegen November 4, 2024 08:15

gentlementlegen requested changes Nov 4, 2024

View reviewed changes

whilefoo suggested changes Nov 4, 2024

View reviewed changes

src/types/plugin-input.ts Outdated Show resolved Hide resolved

src/utils/issue.ts Outdated Show resolved Hide resolved

Keyrxng reviewed Nov 4, 2024

View reviewed changes

src/plugin.ts Outdated Show resolved Hide resolved

ubiquity-os bot added 4 commits November 4, 2024 22:30

fix: process review comments

8fcedd9

fix: renamed checkIssues to assignedIssueScope

87e7b16

fix: convert AssignedIssueScope to enum

986261a

fix: handle search API private repo

d8fead7

ariesgun requested a review from gentlementlegen November 4, 2024 23:01

whilefoo reviewed Nov 5, 2024

View reviewed changes

manifest.json Outdated Show resolved Hide resolved

fix: undo changes in manifest

3827d28

gentlementlegen approved these changes Nov 7, 2024

View reviewed changes

whilefoo approved these changes Nov 7, 2024

View reviewed changes

gentlementlegen merged commit 6a013ba into ubiquity-os-marketplace:development Nov 8, 2024
2 checks passed

ubiquity-os-beta bot mentioned this pull request Nov 9, 2024

Task Limit Improvements #64

Closed

feat: task limit improvement #66

feat: task limit improvement #66

Conversation

ariesgun commented Oct 20, 2024

0x4007 commented Oct 20, 2024

ariesgun commented Oct 20, 2024

0x4007 commented Oct 20, 2024 • edited Loading

ariesgun commented Oct 21, 2024

0x4007 commented Oct 22, 2024

ariesgun commented Oct 26, 2024

0x4007 commented Oct 27, 2024

ariesgun commented Oct 28, 2024

0x4007 commented Oct 28, 2024 • edited Loading

This comment was marked as resolved.

This comment has been minimized.

whilefoo left a comment

Choose a reason for hiding this comment

0x4007 commented Oct 31, 2024

gentlementlegen commented Nov 1, 2024

0x4007 commented Nov 1, 2024

ubiquity-os-beta bot commented Nov 2, 2024

gentlementlegen commented Nov 2, 2024

0x4007 commented Nov 2, 2024

gentlementlegen commented Nov 2, 2024

ariesgun commented Nov 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentlementlegen commented Nov 6, 2024 • edited Loading

ariesgun commented Nov 6, 2024

0x4007 commented Oct 20, 2024 •

edited

Loading

0x4007 commented Oct 28, 2024 •

edited

Loading

gentlementlegen commented Nov 6, 2024 •

edited

Loading