fix: the warning for the disqualification is not posted on tasks with…

… no price label

src/handlers/watch-user-activity.ts

@@ -2,7 +2,7 @@ import { RestEndpointMethodTypes } from "@octokit/rest";
 import { postComment } from "@ubiquity-os/plugin-sdk";
 import { formatMillisecondsToHumanReadable } from "./time-format";
 import { getWatchedRepos } from "../helpers/get-watched-repos";
-import { parsePriorityLabel } from "../helpers/task-metadata";
+import { parsePriceLabel, parsePriorityLabel } from "../helpers/task-metadata";
 import { updateTaskReminder } from "../helpers/task-update";
 import { ListForOrg } from "../types/github-types";
 import { ContextPlugin } from "../types/plugin-input";
@@ -48,8 +48,16 @@ export async function watchUserActivity(context: ContextPlugin) {
   return { message: "OK" };
 }
 
+/*
+ * We ignore the issue if:
+ * - draft
+ * - pull request
+ * - locked
+ * - not in "open" state
+ * - not priced (no price label found)
+ */
 function shouldIgnoreIssue(issue: IssueType) {
-  return issue.draft || issue.pull_request || issue.locked || issue.state !== "open";
+  return !!issue.draft || !!issue.pull_request || issue.locked || issue.state !== "open" || parsePriceLabel(issue.labels) === null;
 }
 
 async function updateReminders(context: ContextPlugin, repo: ListForOrg["data"][0]) {
@@ -67,13 +75,13 @@ async function updateReminders(context: ContextPlugin, repo: ListForOrg["data"][
 
   await Promise.all(
     issues.map(async (issue) => {
-      // I think we can safely ignore the following
       if (shouldIgnoreIssue(issue)) {
-        logger.debug(`Skipping issue ${issue.html_url} due to the issue not meeting the right criteria.`, {
+        logger.info(`Skipping issue ${issue.html_url} due to the issue not meeting the right criteria.`, {
           draft: issue.draft,
           pullRequest: !!issue.pull_request,
           locked: issue.locked,
           state: issue.state,
+          priceLabel: parsePriceLabel(issue.labels),
         });
         return;
       }

src/helpers/task-metadata.ts

@@ -122,3 +122,14 @@ export function parsePriorityLabel(labels: (IssueLabel | string)[]): number {
 
   return 1;
 }
+
+export function parsePriceLabel(labels: (IssueLabel | string)[]): number | null {
+  const priceLabel = labels?.map((label) => (typeof label === "string" ? label : label.name || "")).find((name) => name.toLowerCase().startsWith("price:"));
+
+  if (!priceLabel) {
+    return null;
+  }
+
+  const matched = priceLabel.match(/price:\s*(\d+)/i);
+  return matched ? Number(matched[1]) : null;
+}

tests/assign.test.ts

@@ -1,4 +1,4 @@
-import { jest } from "@jest/globals";
+import { beforeEach, describe, expect, it, jest } from "@jest/globals";
 import { Logs } from "@ubiquity-os/ubiquity-os-logger";
 import { ContextPlugin } from "../src/types/plugin-input";
 
@@ -13,7 +13,7 @@ jest.unstable_mockModule("@ubiquity-os/plugin-sdk", () => ({
 const { watchUserActivity } = await import("../src/handlers/watch-user-activity");
 
 describe("watchUserActivity", () => {
-  const mockContext = {
+  const mockContextTemplate = {
     logger: new Logs("debug"),
     eventName: "issues.assigned",
     payload: {
@@ -46,14 +46,34 @@ describe("watchUserActivity", () => {
     jest.clearAllMocks();
   });
 
-  test("posts comment for matching repository issue", async () => {
+  it("should post comment for matching repository issue", async () => {
     const spy = jest.spyOn(console, "warn");
-    await watchUserActivity(mockContext);
+    const mockContext = {
+      ...mockContextTemplate,
+    };
+    mockContext.payload = {
+      ...mockContextTemplate.payload,
+      issue: {
+        assignees: [{ login: "ubiquity-os" }],
+        title: "Test Issue",
+        state: "open",
+        labels: ["Price: 1 USD"],
+      },
+    } as unknown as ContextPlugin["payload"];
 
+    await watchUserActivity(mockContext);
     expect(spy).toHaveBeenNthCalledWith(
       1,
       expect.stringMatching(/(Reminders will be sent every `1 hour` if there is no activity\.|Assignees will be disqualified after `2 hours` of inactivity\.)/)
     );
     spy.mockReset();
   });
+
+  it("should ignore an un-priced task", async () => {
+    const spy = jest.spyOn(console, "info");
+
+    await watchUserActivity(mockContextTemplate);
+    expect(spy).not.toHaveBeenCalled();
+    spy.mockReset();
+  });
 });