refactor: remove runId

ubiquity-os · Oct 16, 2024 · 5b20c35 · 5b20c35
1 parent ff0d9d9
commit 5b20c35
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/scripts/github-action-permit-generator.ts b/scripts/github-action-permit-generator.ts
@@ -14,8 +14,6 @@ import * as fs from "fs";
  * Generates all the permits based on the current github workflow dispatch.
  */
 export async function generatePermitsFromGithubWorkflowDispatch() {
-  const runId = github.context.runId;
-
   // These are necessary to ensure the type checks and tests pass.
   process.env["NFT_MINTER_PRIVATE_KEY"] = "";
   process.env["NFT_CONTRACT_ADDRESS"] = "";
@@ -52,7 +50,6 @@ export async function generatePermitsFromGithubWorkflowDispatch() {
     evmNetworkId: Number(env.EVM_NETWORK_ID),
     evmPrivateEncrypted: env.EVM_PRIVATE_KEY,
     permitRequests: permitRequests,
-    runId: runId,
   };
 
   const octokit = new Octokit({ auth: env.GITHUB_TOKEN });

diff --git a/src/handlers/generate-erc20-permit.ts b/src/handlers/generate-erc20-permit.ts
@@ -55,10 +55,8 @@ export async function generateErc20PermitSignature(
       issueNodeId = contextOrPayload.payload.issue.node_id;
     } else if ("pull_request" in contextOrPayload.payload) {
       issueNodeId = contextOrPayload.payload.pull_request.node_id;
-    } else if (contextOrPayload.config.runId) {
-      issueNodeId = uuid();
     } else {
-      throw new Error("Issue Id is missing");
+      issueNodeId = uuid();
     }
   }