-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive setup #198
Interactive setup #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works well!
@whilefoo might have been corrected in later wrangler versions, I remember issues when there was either multiple accounts or multiple KV name spaces that would stop wrangler from working. I'll give this a try soon. |
@gentlementlegen daemon-merge should take daemon-disqualifier into account. Merge is designed to merge when reviewers are too slow Disqualifier may disqualify before the merge occurs so we need a solution for the merge to happen just before the disqualification. |
@henalolp, this task has been idle for a while. Please provide an update. |
I have started working on the task and it is going well. But I was notified that some one was assigned before and he is still working on it, should I have to continue wirking on the task ? |
@gentlementlegen this looks wrong |
@henalolp is currently the user assigned to the task so it makes sense to me? What was expected |
This is whilefoo pull request so it doesn't make sense to follow up here for someone else. Should default to follow up on the issue in this scenario. |
@0x4007 This PR should have been closed in the first place because a user that is not assigned should get denied from opening PRs linked to that issue either way. |
Resolves #171
Two new scripts
setup.ts
: create a Github App and stores all required variables in env filedeploy.ts
: checks if wrangler is installed, if user is logged in, asks if you want to upload secrets from env to cloudflare, creates KV namespace (even though it's not used right now), and deploys the worker@gentlementlegen I'm not sure if it's still necessary to add KV namespace to the root of the TOML because when I deployed it, it chose the correct KV id, maybe you know more about this since you made the script