Implement post instanciation method call on service #20
Conversation
armandabric
changed the title
| */ | ||
| Call.prototype.trigger = function trigger(container, instance) { | ||
| if (!instance[this.methodName]) { | ||
| throw new Error('Can\'t call the given method: "' + this.methodName + '" does not exist on the given instance.'); |
There was a problem hiding this comment.
So... we will never know until runtime that the method is unknown isn't it? So... the big question is... do we have to be able to launch some kind of checks at container's instanciation? In this case we maybe should collect all checks in a heap and delegate the exception throwing to a dedicated class that will be specialized in heap checks assertions?
There was a problem hiding this comment.
I've add check on container initialization. These check stay "just in case".
armandabric
changed the title
| @@ -15,6 +15,11 @@ var Container = function Container(serviceDefinitionCollection, parameterCollect | |||
| this.parameterCollection = parameterCollection; | |||
|
|
|||
| this.serviceStorage = new ServiceStorage(); | |||
|
|
|||
| if (process.env.NODE_ENV === 'development') { | |||
There was a problem hiding this comment.
Maybe, instead of being hard coupled to NODE_ENV here... this could become an argument of the Container constructor?
There was a problem hiding this comment.
Something like:
function Container(serviceDefinitionCollection, parameterCollection, boolean: validateDefinitions)There was a problem hiding this comment.
Ho 😱 That's a really good idea!
There was a problem hiding this comment.
I will need to add it to the ContainerFactory too.
|
LGTM, good to squash then merge! 👍 |
Implement post instanciation method call on service
ServiceArgumentCollectiontoArgumentCollectionandServiceArgumenttoArgument