Fix GitHib Actions build workflow (#394)

* Bump Microsoft.NET.Test.Sdk from 17.0.0 to 17.12.0 Fix known high severity vulnerability NuGet error in Sharpmake.UnitTests. * Avoid NuGet security vulnerabilities audit warnings breaks the build in PackageReference sample * Split HelloIOS sample into distinct GitHub and GitLab versions Device names that need to be used are different because of available XCode version. We also allow test execution to fail on GitHub since simulator startup can sometime timeout.
ubisoft · Nov 28, 2024 · 081f451 · 081f451
1 parent 88e2c86
commit 081f451
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 3 deletions.
diff --git a/SamplesDef.json b/SamplesDef.json
@@ -474,8 +474,23 @@
             ]
         },
         {
-            "Name": "HelloIOS",
-            "CIs": [ "github", "gitlab" ],
+            "Name": "HelloIOS-github",
+            "CIs": [ "github" ],
+            "OSs": [ "macos" ],
+            "Frameworks": [ "net6.0" ],
+            "Configurations": [ "debug", "release" ],
+            "TestFolder": "samples/HelloIOS",
+            "Commands":
+            [
+                "xcodebuild -version",
+                "./RunSharpmake.ps1 -workingDirectory {testFolder} -sharpmakeFile \"HelloIOS.Main.sharpmake.cs\" -framework {framework}",
+                "xcodebuild build-for-testing CODE_SIGNING_ALLOWED=NO -workspace {testFolder}/codebase/temp/solutions/HelloIOS_iOS.xcworkspace -configuration {configuration} -scheme exe_iOS -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 15 Pro'",
+                "xcodebuild test-without-building  -workspace {testFolder}/codebase/temp/solutions/HelloIOS_iOS.xcworkspace -configuration {configuration} -scheme exe_iOS -destination 'platform=iOS Simulator,name=iPhone 15 Pro' -derivedDataPath {testFolder}/test; $global:LastExitCode = 0"
+            ]
+        },
+        {
+            "Name": "HelloIOS-gitlab",
+            "CIs": [ "gitlab" ],
             "OSs": [ "macos" ],
             "Frameworks": [ "net6.0" ],
             "Configurations": [ "debug", "release" ],

diff --git a/Sharpmake.UnitTests/Sharpmake.UnitTests.csproj b/Sharpmake.UnitTests/Sharpmake.UnitTests.csproj
@@ -16,7 +16,7 @@
     <PackageReference Include="NUnit3TestAdapter" Version="4.1.0" />
     <PackageReference Include="NUnit" Version="3.13.2" />
     <PackageReference Include="NUnit.Console" Version="3.12.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
   </ItemGroup>
 
   <Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" />

diff --git a/samples/PackageReferences/PackageReferences.sharpmake.cs b/samples/PackageReferences/PackageReferences.sharpmake.cs
@@ -40,6 +40,10 @@ public virtual void ConfigureAll(Configuration conf, Target target)
 
             conf.Options.Add(Options.CSharp.TreatWarningsAsErrors.Enabled);
 
+            // Avoid NuGet security vulnerabilities audit warnings breaks the build.
+            // .NET Framework 4.x has known vulnerabilities.
+            conf.Options.Add(new Options.CSharp.WarningsNotAsErrors("NU1901", "NU1902", "NU1903", "NU1904"));
+
             conf.ReferencesByNuGetPackage.Add("NUnit", "3.6.0");
             conf.ReferencesByNuGetPackage.Add("Newtonsoft.Json", "13.0.1");
             conf.ReferencesByNuGetPackage.Add("Mono.Cecil", "0.9.6.4", privateAssets: Sharpmake.PackageReferences.AssetsDependency.All);

diff --git a/...s/reference/projects/csharppackagereferences/CSharpPackageReferences.vs2019.v4_7_2.csproj b/...s/reference/projects/csharppackagereferences/CSharpPackageReferences.vs2019.v4_7_2.csproj
@@ -22,6 +22,7 @@
     <DefineConstants>DEBUG;TRACE;WIN64</DefineConstants>
     <WarningLevel>4</WarningLevel>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <WarningsNotAsErrors>NU1901,NU1902,NU1903,NU1904</WarningsNotAsErrors>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
@@ -34,6 +35,7 @@
     <DefineConstants>TRACE;WIN64</DefineConstants>
     <WarningLevel>4</WarningLevel>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <WarningsNotAsErrors>NU1901,NU1902,NU1903,NU1904</WarningsNotAsErrors>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <ItemGroup>

diff --git a/...s/reference/projects/csharppackagereferences/CSharpPackageReferences.vs2022.v4_7_2.csproj b/...s/reference/projects/csharppackagereferences/CSharpPackageReferences.vs2022.v4_7_2.csproj
@@ -22,6 +22,7 @@
     <DefineConstants>DEBUG;TRACE;WIN64</DefineConstants>
     <WarningLevel>4</WarningLevel>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <WarningsNotAsErrors>NU1901,NU1902,NU1903,NU1904</WarningsNotAsErrors>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
@@ -34,6 +35,7 @@
     <DefineConstants>TRACE;WIN64</DefineConstants>
     <WarningLevel>4</WarningLevel>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <WarningsNotAsErrors>NU1901,NU1902,NU1903,NU1904</WarningsNotAsErrors>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <ItemGroup>