-
Notifications
You must be signed in to change notification settings - Fork 40
feat(just): combine several just commands into toggles or choices #181
Conversation
I have left |
Distrobox file will require some more thought on what would be the best approach, will do that one later as it is fine as it is for now. |
+1 to the changes, let's see what others think. I'd like to shove your reasoning for each verb in a readme at the root of the dir so we have it going forward, but we can do that in a follow up PR. We can also do the distrobox in a follow up PR so that this doesn't keep growing, better to land it in smaller chunks. Thanks for working on this! |
It is why i want to see what others think first before it gets fully committed to going forward
Np! someone has to do it 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look great! Definitely a significant improvement over what we have. Just a note - in the future, we should implement quick toggles/selections for these so that they can be used in other places like yafti. I.E., for configure-gamepads
, we could have configure-gamepads stock
or configure-gamepads ublue
need to play around with it and figure out how it works first in just and do some tests as i was thinking we could do something as simple as just feeding the ugum choice return value to the command or something. |
…writing the just recipes
…change brew-remove to remove-brew
f2ba176
to
430c840
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great. Bazzite just needs a couple things adjusted in yafti and then this will be good to go :)
48e2346
to
c6cb6e6
Compare
I have a proposal: Can we change the extremely long list of distrobox- This would fit with the naming scheme you have created and would declutter the list of recipes when doing |
I agree with the above statement! I just added several more distroboxes in #185 We are also talking about wanting to support toolbox as well so users have a choice of which they prefer to use! |
will be in separate PR as i have some ideas on how to improve it as i really want to shrink that list too, but i also want to enhance it by letting users apply a name and platform (docker/podman or toolbox) for the distroboxes. |
e53f9e3
to
195893f
Compare
I was just coming here to do a final read and approve! But it's in already! Thanks for the effort @HikariKnight |
This patch, when complete will be the second step in addressing #148 now that we have
ugum
on all images which solved the need of a standardized way to select between options.This is something that i will be chipping away at when i am able to.
Naming scheme for just recipes (draft) will be:
setup-
Used when the recipe provides a way to install and remove something (configuration can also be added here)configure-
Used to configure something that is pre-installed on the ublue system (maybe shorten toconfig-
?)install-
Used by recipes where there is no functionality other than installremove-
used byremove-brew
due to the issues we got reported where it broke flatpak, please ignoretoggle-
switch something on/off like for exampletoggle-gnome-vrr
(if it makes sense maybe ditchtoggle-
and useconfigure-
instead, unless we keep toggle for things that are specifically on/off switches?)fix-
Apply a patch/workaround to somethingthing
A single task that works as a shortcut and needs to be memorable, likeupdate
orchangelog
Also i have added aliases to provide a shorter name for recipes too where i felt it was warranted.
Input about this proposed scheme is appreciated before merging
Snippet for choice dialogs (adjust for your needs)
If you have a lot of options (more than 3?) you can do what i did for nix for readablilty
Using
ugum
(universal gum) will let it generate choice dialogs even whengum
is not installed, they will look something like this:With

gum
installed, gum will be prioritized:Without

gum
but withfzf
is installed, fallback to fzf:Without both

fzf
andgum
, fallback to pure bash: