Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hold update until the app creates a file signaling it is loaded - closes #177 #208

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Jan 10, 2025

This PR includes renaming ubo_app.logging to ubo_app.logger as latest version of ruff raises an error for naming a module "logging" because it is a reserved module name in standard library.
It is causing lots of minor irrelevant files being listed in the diff, we can ignore all such changes.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ubo_app/error_handlers.py 0.00% 3 Missing ⚠️
ubo_app/main.py 0.00% 2 Missing ⚠️
ubo_app/services/030-wifi/wifi_manager.py 0.00% 1 Missing ⚠️
ubo_app/setup.py 0.00% 1 Missing ⚠️
ubo_app/system/bootstrap.py 0.00% 1 Missing ⚠️
ubo_app/system/system_manager/audio.py 0.00% 1 Missing ⚠️
ubo_app/system/system_manager/led.py 0.00% 1 Missing ⚠️
ubo_app/system/system_manager/main.py 0.00% 1 Missing ⚠️
ubo_app/system/system_manager/package.py 0.00% 1 Missing ⚠️
ubo_app/system/system_manager/reset_button.py 0.00% 1 Missing ⚠️
... and 2 more
Flag Coverage Δ
ubuntu-latest 58.07% <61.53%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/load_services.py 90.90% <100.00%> (ø)
ubo_app/logger.py 59.09% <ø> (ø)
ubo_app/menu_app/menu_central.py 69.53% <100.00%> (ø)
ubo_app/service.py 96.87% <100.00%> (ø)
ubo_app/services/000-audio/audio_manager.py 44.94% <100.00%> (ø)
...vices/030-wifi/pages/create_wireless_connection.py 46.15% <100.00%> (ø)
ubo_app/services/030-wifi/setup.py 84.09% <100.00%> (ø)
ubo_app/services/040-rgb-ring/rgb_ring_client.py 78.57% <100.00%> (ø)
ubo_app/services/050-rpi-connect/commands.py 34.88% <100.00%> (ø)
ubo_app/services/050-rpi-connect/sign_in_page.py 52.17% <100.00%> (ø)
... and 25 more

Copy link
Collaborator

@zytegalaxy zytegalaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! please merge

@sassanh sassanh merged commit 573fb17 into main Jan 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants