Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let the user upload directory content of the docker composition they are creating - closes #202 #210

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Jan 12, 2025

Things done in this pull request:

  1. Add a way to upload files in web-ui
  2. Update data structures related to reporting result of the ubo_input in store and in its imperative mode to include files field which is a dict of field name -> file stream.
  3. Utilize above items in docker composition input form so that the user can upload a file along the docker composition properties. It should be .zip, .tar.gz, .tar.bz2, or .tar.xz. It will then decompress that file and put its content next to the docker-compose.yml file.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 35.00000% with 91 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ubo_app/services/090-web-ui/setup.py 34.21% 25 Missing ⚠️
ubo_app/system/system_manager/hotspot.py 0.00% 23 Missing ⚠️
ubo_app/services/080-docker/setup.py 4.54% 21 Missing ⚠️
...vices/030-wifi/pages/create_wireless_connection.py 14.28% 6 Missing ⚠️
ubo_app/store/services/voice.py 64.28% 5 Missing ⚠️
ubo_app/utils/input.py 33.33% 4 Missing ⚠️
ubo_app/system/system_manager/reset_button.py 0.00% 3 Missing ⚠️
ubo_app/services/010-voice/setup.py 0.00% 1 Missing ⚠️
ubo_app/store/update_manager/utils.py 50.00% 1 Missing ⚠️
ubo_app/system/system_manager/main.py 0.00% 1 Missing ⚠️
... and 1 more
Flag Coverage Δ
ubuntu-latest 57.46% <35.00%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/logger.py 59.55% <100.00%> (+0.45%) ⬆️
ubo_app/menu_app/menu_notification_handler.py 26.04% <ø> (ø)
ubo_app/services/010-voice/reducer.py 81.25% <ø> (ø)
ubo_app/services/030-wifi/setup.py 84.44% <100.00%> (+0.35%) ⬆️
ubo_app/services/040-camera/reducer.py 54.76% <ø> (ø)
ubo_app/services/050-rpi-connect/commands.py 35.63% <100.00%> (+0.74%) ⬆️
ubo_app/services/050-users/setup.py 67.44% <100.00%> (+0.38%) ⬆️
ubo_app/services/080-docker/docker_images.py 100.00% <100.00%> (ø)
ubo_app/services/080-docker/menus.py 40.81% <100.00%> (+1.23%) ⬆️
ubo_app/services/090-web-ui/reducer.py 83.33% <100.00%> (-2.39%) ⬇️
... and 17 more

@sassanh sassanh force-pushed the wifi-hotspot branch 5 times, most recently from a3c2eaf to 06420b1 Compare January 13, 2025 10:48
@zytegalaxy zytegalaxy self-requested a review January 16, 2025 02:49
Copy link
Collaborator

@zytegalaxy zytegalaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! please merge together with other approved PRs. I will test the experience after merge. The changes should only impact web UI part I believe.

@zytegalaxy zytegalaxy assigned zytegalaxy and sassanh and unassigned zytegalaxy Jan 16, 2025
@sassanh sassanh force-pushed the provide-docker-compose-directory-content branch from 8c99bbc to 438db6a Compare January 16, 2025 15:10
@sassanh sassanh changed the base branch from wifi-hotspot to main January 16, 2025 15:12
@sassanh sassanh force-pushed the provide-docker-compose-directory-content branch from 438db6a to c5ff619 Compare January 16, 2025 15:32
@sassanh sassanh merged commit 9d61617 into main Jan 16, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants