Improvements on accessibility of the hotspot interface of the web-ui #221

sassanh · 2025-01-25T23:30:51Z

This pull request includes:

Several commits addressing Bring up WiFi Hotspot at boot up if no SSID has been previously registered #214, automatically running the wifi connection creation procedure when it boots and there is no ssid saved on the pod and it is not connected to internet.
Several commits addressing Show web UI with nodogsplash captive portal when connecting to hotspot #211, using nodogsplash to provide captive portal for the webui interface in the hotspot.
A commit Fixing App crashed when testing wifi hotspot: AttributeError: 'list' object has no attribute 'id' #212 (a typo, causing runtime error when running the web-ui input for the second time)
A commit Fixing high CPU usage ubo-system on ubo #216 (high cpu usage of system-manager service)
A commit adding utility function to apply bunch of templates to the filesystem
A commit using new ARM64 github runner for building images which makes them run 2x faster and avoids the regular random failures.

It also fixes one of the reasons #223 happens as an inline change done in the last commit

* add keyboard shortcuts readme * Update ubo_app/services/020-keyboard/shortcuts.md Co-authored-by: Sassan Haradji <[email protected]> * Update ubo_app/services/020-keyboard/shortcuts.md Co-authored-by: Sassan Haradji <[email protected]> * Update ubo_app/services/020-keyboard/shortcuts.md Co-authored-by: Sassan Haradji <[email protected]> * Update ubo_app/services/020-keyboard/shortcuts.md Co-authored-by: Sassan Haradji <[email protected]> * Update ubo_app/services/020-keyboard/shortcuts.md Co-authored-by: Sassan Haradji <[email protected]> * updated readme for keyboard/keypad shortcuts * remove avanced label. * clarify what snapshot means * make key names more consistent * more consistency --------- Co-authored-by: Sassan Haradji <[email protected]>

codecov · 2025-01-25T23:32:58Z

Codecov Report

Attention: Patch coverage is 26.75439% with 167 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
ubo_app/system/system_manager/hotspot.py	0.00%	26 Missing ⚠️
...vices/030-wifi/pages/create_wireless_connection.py	7.40%	25 Missing ⚠️
ubo_app/system/redirect_server.py	0.00%	24 Missing ⚠️
ubo_app/utils/template_files.py	0.00%	24 Missing ⚠️
ubo_app/system/hotspot_config.py	0.00%	13 Missing ⚠️
ubo_app/system/system_manager/main.py	0.00%	13 Missing ⚠️
ubo_app/utils/network.py	66.66%	11 Missing ⚠️
ubo_app/logger.py	55.00%	9 Missing ⚠️
ubo_app/services/090-web-ui/setup.py	18.18%	9 Missing ⚠️
ubo_app/system/bootstrap.py	0.00%	7 Missing ⚠️
... and 4 more

Flag	Coverage Δ
ubuntu-latest	`57.28% <26.75%> (-0.15%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
ubo_app/constants.py	`100.00% <100.00%> (ø)`
ubo_app/services/030-wifi/setup.py	`84.78% <100.00%> (+0.33%)`	⬆️
ubo_app/services/090-web-ui/reducer.py	`83.33% <ø> (ø)`
ubo_app/store/core/reducer.py	`60.30% <ø> (ø)`
ubo_app/store/services/web_ui.py	`100.00% <100.00%> (ø)`
ubo_app/store/services/wifi.py	`100.00% <100.00%> (ø)`
ubo_app/services/000-audio/audio_manager.py	`45.05% <66.66%> (+0.11%)`	⬆️
ubo_app/services/030-wifi/reducer.py	`85.71% <50.00%> (-3.76%)`	⬇️
ubo_app/side_effects.py	`52.74% <83.33%> (+4.64%)`	⬆️
ubo_app/utils/pod_id.py	`58.82% <75.00%> (+58.82%)`	⬆️
... and 10 more

ubo_app/services/090-web-ui/setup.py

zytegalaxy

It's working like a charm! There's one minor change request (adding wifi password to notification info). Please merge after making that change. No need for manual testing.

ubo_app/services/000-audio/audio_manager.py

…e is no ssid saved in the network manager and no default gateway is set - closes #214

…loses #211

…uts instead of a list due to an unwanted comma - closes #212

…en the ping raised an exception - closes #216

…ased on a templates directory, while taking backups of the original files and another utility function to restore the backups

… to avoid the soft block - closes #222

…tspot fails in the system manager

…em services to the `ubo-hotspot` service (the more general version of the `ubo-redirect-server` service which runs the redirect server as its main process.)

sassanh requested a review from zytegalaxy January 25, 2025 23:31

sassanh self-assigned this Jan 25, 2025

This was linked to issues Jan 25, 2025

Show web UI with nodogsplash captive portal when connecting to hotspot #211

Closed

Bring up WiFi Hotspot at boot up if no SSID has been previously registered #214

Closed

sassanh temporarily deployed to test January 25, 2025 23:31 — with GitHub Actions Inactive

sassanh deployed to pypi January 25, 2025 23:35 — with GitHub Actions View deployment

sassanh force-pushed the automatic-wifi-creation-procedure branch from 9821b5f to d41e918 Compare January 26, 2025 02:04

sassanh temporarily deployed to test January 26, 2025 02:05 — with GitHub Actions Inactive

sassanh force-pushed the automatic-wifi-creation-procedure branch from d41e918 to feb90c1 Compare January 26, 2025 02:06

sassanh had a problem deploying to test January 26, 2025 02:09 — with GitHub Actions Error

sassanh had a problem deploying to test January 26, 2025 02:09 — with GitHub Actions Failure

sassanh temporarily deployed to test January 26, 2025 02:15 — with GitHub Actions Inactive

sassanh deployed to pypi January 26, 2025 02:19 — with GitHub Actions View deployment

sassanh force-pushed the automatic-wifi-creation-procedure branch from feb90c1 to b0cb01a Compare January 26, 2025 03:17

sassanh temporarily deployed to test January 26, 2025 03:17 — with GitHub Actions Inactive

sassanh deployed to pypi January 26, 2025 03:21 — with GitHub Actions View deployment

sassanh force-pushed the automatic-wifi-creation-procedure branch from b0cb01a to 58c9f37 Compare January 26, 2025 10:32

sassanh temporarily deployed to test January 26, 2025 10:32 — with GitHub Actions Inactive

sassanh had a problem deploying to pypi January 29, 2025 10:42 — with GitHub Actions Failure

zytegalaxy reviewed Jan 29, 2025

View reviewed changes

ubo_app/services/090-web-ui/setup.py Show resolved Hide resolved

zytegalaxy approved these changes Jan 29, 2025

View reviewed changes

sassanh temporarily deployed to test January 30, 2025 11:35 — with GitHub Actions Inactive

sassanh had a problem deploying to pypi January 30, 2025 11:39 — with GitHub Actions Error

sassanh force-pushed the automatic-wifi-creation-procedure branch from 56fde35 to e913d37 Compare January 30, 2025 11:48

sassanh temporarily deployed to test January 30, 2025 11:48 — with GitHub Actions Inactive

sassanh had a problem deploying to pypi January 30, 2025 11:52 — with GitHub Actions Failure

zytegalaxy reviewed Jan 30, 2025

View reviewed changes

ubo_app/services/000-audio/audio_manager.py Show resolved Hide resolved

sassanh added 10 commits January 31, 2025 07:57

feat(web-ui): automatically run the wifi creation procedure when ther…

10db110

…e is no ssid saved in the network manager and no default gateway is set - closes #214

feat(web-ui): use captive portal in the hotspot started by web-ui - c…

21dc8c2

…loses #211

fix(core): an issue where a tuple of lists where passed as active_inp…

e169f1f

…uts instead of a list due to an unwanted comma - closes #212

fix(core): high cpu usage due to the while loop going non-blocking wh…

9041872

…en the ping raised an exception - closes #216

feat(core): add a utility function to apply templates to filesystem b…

a23d338

…ased on a templates directory, while taking backups of the original files and another utility function to restore the backups

fix(web-ui): run iw wlan0 set power_save off before running hotspot…

8f819a2

… to avoid the soft block - closes #222

refactor(ci): use new github runner arm images for building images

9a2951d

feat(web-ui): add ubo-redirect-server service

e0c0560

refactor(web-ui): add notifications for when starting/stopping the ho…

9725dc3

…tspot fails in the system manager

refactor(web-ui): move starting/stopping of the required hotspot syst…

8a5b4d8

…em services to the `ubo-hotspot` service (the more general version of the `ubo-redirect-server` service which runs the redirect server as its main process.)

sassanh force-pushed the automatic-wifi-creation-procedure branch from e913d37 to 8a5b4d8 Compare January 31, 2025 04:42

sassanh temporarily deployed to test January 31, 2025 04:43 — with GitHub Actions Inactive

sassanh enabled auto-merge (rebase) January 31, 2025 04:45

sassanh had a problem deploying to pypi January 31, 2025 04:46 — with GitHub Actions Failure

sassanh merged commit a563c3e into main Jan 31, 2025
10 of 12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvements on accessibility of the hotspot interface of the web-ui #221

Improvements on accessibility of the hotspot interface of the web-ui #221

sassanh commented Jan 25, 2025 •

edited

Loading

codecov bot commented Jan 25, 2025 •

edited

Loading

zytegalaxy left a comment

Improvements on accessibility of the hotspot interface of the web-ui #221

Improvements on accessibility of the hotspot interface of the web-ui #221

Conversation

sassanh commented Jan 25, 2025 • edited Loading

codecov bot commented Jan 25, 2025 • edited Loading

Codecov Report

zytegalaxy left a comment

Choose a reason for hiding this comment

sassanh commented Jan 25, 2025 •

edited

Loading

codecov bot commented Jan 25, 2025 •

edited

Loading