Rnaiser: Design part one #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you do now the squash and merge or should i merge pull request now and you to the squash and merge afterwards ? |
mtrojan-ub
commented
Mar 6, 2024
mtrojan-ub
commented
Mar 6, 2024
mtrojan-ub
commented
Mar 6, 2024
| <a href="http://www.neg.uni-tuebingen.de/?q=de/ziele"> Ziele </a>| | ||
| <a href="<%=Utils.getBaseUrl(request)%>/gast/impressum"> Impressum </a> | ||
| </p> | ||
| <footer id="ut-identifier--footer" class="ut-page__footer ut-page-footer"> |
There was a problem hiding this comment.
If you look at the footer at a small resolution (e.g. <=767), the panels in the footer will collapse, and you will not be able to expand them again. I am not sure whether this is a class-related problem or a JS related problem.
mtrojan-ub
commented
Mar 6, 2024
mtrojan-ub
commented
Mar 6, 2024
| out.println(e); | ||
| } finally { | ||
| try { | ||
| if (null != rs) { |
There was a problem hiding this comment.
Unfortunately inc.modul.jsp is still managing its own SQL connections, but this might be out of scope for the current PR (we should not forget about this anyway).
There was a problem hiding this comment.
will be done in another pr, i wrote it to my to-do list
Einzelbeleg hatareal
Fixes selektion arealtyp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rnaiser: I had to re-open this PR after pulling
developintodesignelse the PR would show too many changes.