updating getContainerIdsWithTitle logic #2730 #2741
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrojan-ub
reviewed
Feb 26, 2024
| @@ -663,7 +668,18 @@ String getPPNFromWSubfield(final DataField field) { | |||
| public Set<String> getContainerIdsWithTitles(final Record record) { | |||
| final Set<String> containerIdsTitlesAndOptionalVolumes = new TreeSet<>(); | |||
|
|
|||
| for (final String tag : new String[] { "773", "800", "810", "830" }) { | |||
| IssueInfo issue_info_773_or_936(getIssueInfo(record)); | |||
There was a problem hiding this comment.
I think it's OK to use the simpler variable name issue_info here instead of issue_info_773_or_996. Which tags the function used is just an implementation detail that can change at any time and then we would have to change all variable names so better just change it now and use a short one.
mtrojan-ub
pushed a commit
that referenced
this pull request
Feb 28, 2024
|
Initially this PR was intended to be a short bugfix, but it turned out we cannot fully repair this without side effects. Also, there is still an ongoing discussion about requirements regarding all aspects where containers / superior works should be shown in which way in the frontend, so we should wait until the discussion is finished before making further changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.