Update system call for composer #4579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrojan-ub
reviewed
Nov 13, 2024
| @@ -809,7 +810,8 @@ void ConfigureVuFind(const bool production, const VuFindSystemType vufind_system | |||
| Echo("Configuring vufind"); | |||
| // We need to increase default_socket_timeout for big downloads on slow mirrors, especially Solr (default 60 seconds) . | |||
| TemporaryChDir tmp2(VUFIND_DIRECTORY); | |||
| ExecUtil::ExecOrDie(ExecUtil::LocateOrDie("php"), { "-d", "default_socket_timeout=600", ExecUtil::LocateOrDie("composer"), "install" }); | |||
| system("composer install"); | |||
There was a problem hiding this comment.
Multiple aspects:
- The override of default_socket_timeout is removed (that's why we initially called PHP instead of composer directly)
- Due to our convention (see ExecUtil) system calls should be called with double colons at the start =>
::system() - If it is necessary to use a different system call, then we should create a wrapper function in ExecUtil to do so
- You're just calling system() without checking the result => please check the manpage, you must check the result code against -1 and maybe also output a log message containing
errno.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current system call using 'ExecOrDie' will kill all sub-processes when an error occurs running the composer install. Phing will fail during installation, but Tuefind doesn't need It. Using 'system' for the system call will solve this problem.