Skip to content

Commit

Permalink
Never log a dbus failure to retrieve an optional property
Browse files Browse the repository at this point in the history
Chromium and Electron apps do not implement the IconAccessibleDesc
property and reply to the Get() method with a generic
  org.freedesktop.DBus.Error.Failed

Ignore all DBus errors for optional properties.

Fixes: #534
LP: #2064698
  • Loading branch information
aleasto authored and 3v1n0 committed Aug 13, 2024
1 parent d7b76d6 commit b1db0b6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion appIndicator.js
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ class AppIndicatorProxy extends DBusProxy {
});
} catch (e) {
if (!AppIndicatorProxy.OPTIONAL_PROPERTIES.includes(p) ||
!e.matches(Gio.DBusError, Gio.DBusError.UNKNOWN_PROPERTY))
!(e instanceof Gio.DBusError))
logError(e);
}
}));
Expand Down

0 comments on commit b1db0b6

Please sign in to comment.