Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #226 and #236. There was a function that made exceptions and ca… #243

Closed
wants to merge 2 commits into from
Closed

Fixed #226 and #236. There was a function that made exceptions and ca… #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a355963
Fixed #226 and #236. There was a function that made exceptions and ca…
danieloppenlander May 27, 2020
fa7f646
Update appIndicator.js
danieloppenlander Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions appIndicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,13 @@ class AppIndicators_IconActor extends St.Icon {
}

_createIconByName(path, callback) {
// We must make an early return on null case to gracefully handle null exception.
if (!path) {
Util.Logger.warn(`${this._indicator.id}, Impossible to read image info from path 'null'`);
danieloppenlander marked this conversation as resolved.
Show resolved Hide resolved
callback(null);
return;
}

GdkPixbuf.Pixbuf.get_file_info_async(path, this._cancellable, (_p, res) => {
try {
let [format, width, height] = GdkPixbuf.Pixbuf.get_file_info_finish(res);
Expand Down