Feat/vadc data dictionary table #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved unneeded columns
…nd additional information
…d button for dropdown and columns per design
…earch bar control buttons keyboard accessible, changed location of pagination controls, resolved issue with typescript linting and pagination controls
…hlighting to function for hidden value summary div
…rcentages to JSON
… and recreated test data with unique conceptID values. Added updated icons
…rated out detail tables into seperate components, added preview chart component
jarvisraymond-uchicago
changed the base branch from
master
to
feat/vadc_sprint25
jarvisraymond-uchicago
changed the base branch from
master
to
feat/vadc_sprint01
…ory comment for creating test data with larger sizes
|
@jarvisraymond-uchicago can you please also rename your new DataDictionary folder (and files, class names, etc) to AtlasDataDictionary? This will help us distinguish it from the existing Gen3 DataDictionary that already exists in this same code base (see |
…y to atlas data dictionary
…ionary to atlas data dictionary
Implemented as requested. |
pieterlukasse
approved these changes
Jan 23, 2024
pieterlukasse
approved these changes
Jan 23, 2024
jarvisraymond-uchicago
added a commit
that referenced
this pull request
Jan 31, 2024
* Remove unnecessary outcome prop from histogram rendering (#1459) * feat(dataDictionaryAppPlaceholder): Initial commit * feat(dataDictionaryAppPlaceholder): Ran linter * feat(vadcDataDictionaryTable): Initial commit * feat(vadcDataDictionaryTable): created working table header abstraction * feat(vadcDataDictionaryTable): Wrote styles for tableHeaders and removed unneeded columns * feat(vadcDataDictionaryTable): added entries header * feat(vadcDataDictionaryTable): Updated component sort logic * feat(vadcDataDictionaryTable): Simplified functions for updating arrows CSS classes * feat(vadcDataDictionaryTable): added secondary row to hold data viz and additional information * feat(vadcDataDictionaryTable): Added search * feat(vadcDataDictionaryTable): Added search highlighting * feat(vadcDataDictionaryTable): Added search highlighting for hidden items * feat(vadcDataDictionaryTable): added pagination controls: * feat(vadcDataDictionaryTable): Began converting JSX to TSX * feat(vadcDataDictionaryTable): Converted remaining JSX to TSX, changed button for dropdown and columns per design * feat(vadcDataDictionaryTable): Styled and updated expandable row * feat(vadcDataDictionaryTable): fixed length of highlight for expanded chart * feat(vadcDataDictionaryTable): Changed location of search bar, made search bar control buttons keyboard accessible, changed location of pagination controls, resolved issue with typescript linting and pagination controls * feat(vadcDataDictionaryTable): Resolved ESLINT issues, got search highlighting to function for hidden value summary div * feat(vadcDataDictionaryTable): added preprocessing function to add percentages to JSON * feat(vadcDataDictionaryTable): Updated pagination logic, search logic and recreated test data with unique conceptID values. Added updated icons * feat(vadcDataDictionaryTable): Fixed animation for dropdown row, seperated out detail tables into seperate components, added preview chart component * feat(vadcDataDictionaryTable): Updated GenerateTableData * feat(vadcDataDictionaryTable): Removed console log statements * vadcDataDictionaryTable): removed console log * feat(vadcDataDictionaryTable): made css more consistent * feat(vadcDataDictionaryTable): Fixed bug in GenerateTableData, fixed style lint issues in DataDictionary.css and TeamProjectHeader.css * feat(vadcDataDictionaryTable): Abstracted function checkIfCellContainsSearchTerm into CheckSearchTermUtils to better organize and increase testability * feat(vadcDataDictionaryTable): Abstracted out remaining CheckSearchTermUtils * feat(vadcDataDictionaryTable): Wrote unit test for detail tables * feat(vadcDataDictionaryTable): added test for table row text * feat(vadcDataDictionaryTable): fixed linting issues * feat(vadcDataDictionaryTable): Wrote unit tests for CheckSearchTermUtils * feat(vadcDataDictionaryTable): Added tests for PreprocessTableData and SearchBar * feat(vadcDataDictionaryTable): Linted test files * feat(vadcDataDictionaryTable): Added working pagination controls test * feat(vadcDataDictionaryTable): linted test file * feat(vadcDataDictionaryTable): wrote unit test for entries header * feat(vadcDataDictionaryTable): Added working test for Header component * feat(vadcDataDictionaryTable): added test for ColumnHeaders * feat(vadcDataDictionaryTable): fixed test issues and eslint issues * feat(vadcDataDictionaryTable): removed unneeded comments and formated code * feat(vadcDataDictionaryTable): fixed off by one error in entries header props * feat(vadcDataDictionaryTable): ran linter * feat(vadcDataDictionaryTable): Reduced test data size, added explanatory comment for creating test data with larger sizes * feat(vadcDataDictionaryTable): Ran linter * feat(vadcDataDictionaryTable): removed unintentionally changed file * feat(vadcDataDictionaryTable): Renamed folder to AtlasDataDictionary * feat(vadcDataDictionaryTable): changed references from data dictionary to atlas data dictionary * feat(vadcDataDictionaryTable): changed more references from data dictionary to atlas data dictionary * feat(vadcDataDictionaryTable): Removed unneeded console log statement * feat(vadcDataDictionaryTable): changed 2 more references from data dictionary to atlas data dictionary --------- Co-authored-by: Jian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: VADC-828
Notes
New Features
Improvements
Dependency updates