Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for maxSkew #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jackdent
Copy link

Added init-param for maxSkew, to remove bugs to do with out of sync clocks

@jackdent
Copy link
Author

Have added default behaviour and units as requested.

@drt24
Copy link
Member

drt24 commented Oct 21, 2013

Default behaviour is wrong, 0ms is too small, it will break all the time.

@jackdent
Copy link
Author

I didn't want to set a default maxSkew and thereby expose potential relay attacks.

With no maxSkew set it was working fine on most machines that had some from of NTP configured.

@drt24
Copy link
Member

drt24 commented Oct 21, 2013

Pretty sure that maxSkew has nothing to do with relay attacks, a relay could just use its own timestamp anyway. Many clients have clocks that are wrong buy surprisingly large amounts, 0ms is not the default used by raven normally and for good reason.

@jackdent
Copy link
Author

Apologies that meant to read re_p_lay attacks - I doubted there would be an issue, but erred on the side of caution (I'm aware timestamping is sometimes used as a solution). What is the Raven default?

@drt24
Copy link
Member

drt24 commented Oct 21, 2013

From http://www.ucs.cam.ac.uk/support/windows-support/winsuptech/iis/raveniismoduleconfig

Clock Skew Option

If you are unable to be certain of the time sync of a system which will be using your Raven authenticated service you can use the clock skew option in the Ucam Web Auth Config tab of the web server.

You should however be careful not to set too slack a value for this. 5-10 minutes maximum, 2-3 should be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants