Updating dev with most recent dev changes #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thetwam
requested changes
Nov 6, 2024
.github/workflows/ci.yml
Outdated
| @@ -5,6 +5,7 @@ on: | |||
| branches: | |||
| - main | |||
| - 'stable/*' | |||
| - dev-v3.5.0 | |||
There was a problem hiding this comment.
Do we need this for when it's merged in?
CHANGELOG.md
Outdated
|
|
||
| ## [3.5.0] | ||
| ## [3.5.0](https://github.com/ucfopen/UDOIT/compare/stable/3.4.x...dev-v3.5.0) - 2024-11-12 |
There was a problem hiding this comment.
Figure out a link that will work when the dev branch is deleted (tags?)
Thetwam
requested changes
Nov 6, 2024
CHANGELOG.md
Outdated
| - Added a CHANGELOG file to keep better track of the codebase changes (Thank you, [@dmols](https://github.com/dmols)) | ||
| - Made changes to `INSTALL_CANVAS.md` and `INSTALL.md` files to make the installation process a little easier to follow. (Thank you [@SimHoZebs](https://github.com/SimHoZebs)) | ||
| - Added `Makefile` to speed up development process (Thank you, [@SimHoZebs](https://github.com/SimHoZebs)) | ||
| - Changed highlight color of 'alt text' for the UFIXIT form to meet all accessibility standards for color contrast, in [this commit](https://github.com/ucfopen/UDOIT/commit/93f4bdd3b64be23392a0fc16a3df5b4f9f057217) (Thank you, [@dmols](https://github.com/dmols)) |
There was a problem hiding this comment.
I think technically this is just a generic highlight and not specific to alt text, even though that's where I initially found it.
There was a problem hiding this comment.
hmm good point, I'll make that change.
CHANGELOG.md
Outdated
| - Fixed issue where more than one resolved issue in the UFIXIT modal can remain. Before, the modal would only show the most recent one resolved [#892](https://github.com/ucfopen/UDOIT/pull/892) (Thank you, [@ssciolla](https://github.com/ssciolla)) | ||
| - Fixed case where navigating through issues on UFIXIT modal would be difficult or impossible when one is marked as fixed, since the modal will jump back to the resolved one [#888](https://github.com/ucfopen/UDOIT/pull/888) (Thank you, [@ssciolla](https://github.com/ssciolla)) | ||
| - Fixed issue where adding a Youtube API key to your .env file would not make UDOIT automatically consider issues revolving youtube captioning. This was resolved by allowing a 'Full Course Rescan' option in the dropdown menu of the UDOIT welcome screen [#898](https://github.com/ucfopen/UDOIT/pull/898) (Thank you, [@taheralfayad](https://github.com/taheralfayad)) | ||
| - Upgraded php `memory_limit` from 800M to 3500M, and both `max_execution_time` and `fastcgi_read_timeout` from 180 to 300, to allow for php to handle a larger amount of data, and having nginx wait longer for the processes to complete. Changes seen in [this commit](https://github.com/ucfopen/UDOIT/commit/d6c71b59dc3a353fc3d18b048473e1e09bcef423) (Thank you, [@dmols](https://github.com/dmols) and [@Thetwam](https://github.com/Thetwam)) |
There was a problem hiding this comment.
Not so much an "upgrade" as an "increase".
There was a problem hiding this comment.
Fair point, but do you think this belongs in 'bugfixes'? Wasn't sure where it would sit; I only put it here because without it, UDOIT Admin doesn't load at all.
Thetwam
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.