Hotfix for edge case player question overflow. Fixed bad missingItems…

… reference in player.
ucfopen · Jan 8, 2024 · 8473ca6 · 8473ca6
1 parent 5b50a0f
commit 8473ca6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/src-assets/player-assets/player.coffee b/src/src-assets/player-assets/player.coffee
@@ -405,7 +405,7 @@ angular.module('Adventure', ['ngAria', 'ngSanitize'])
 		$scope.missingRequiredItems = $scope.checkInventory(requiredItems)
 
 		if $scope.missingRequiredItems[0]
-			$scope.missingRequiredItemsAltText = missingItems.map((item) -> "#{$scope.itemSelection[$scope.getItemIndex(item.id)].name} (amount: #{requiredItems.find((el) -> el.id is item.id).range});")
+			$scope.missingRequiredItemsAltText = $scope.missingRequiredItems.map((item) -> "#{$scope.itemSelection[$scope.getItemIndex(item.id)].name} (amount: #{requiredItems.find((el) -> el.id is item.id).range});")
 			$scope.next = null
 			return
 

diff --git a/src/src-assets/player-assets/player.scss b/src/src-assets/player-assets/player.scss
@@ -64,6 +64,7 @@ body {
 	position: absolute;
 	width: 0;
 	height: 0;
+	overflow: hidden;
 }
 
 .aria-live-region {
@@ -256,6 +257,8 @@ h1 {
 	box-sizing: border-box;
 	margin-bottom: auto;
 
+	overflow-y: auto;
+
 	background: #fff;
 
 
@@ -493,7 +496,6 @@ h1 {
 	box-sizing: border-box;
 
 	max-height: 250px;
-	overflow-y: auto;
 
 	font-family: 'Lora', serif;