728 mail aliases needs a new test suite #746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbusenius
requested changes
Apr 8, 2024
There was a problem hiding this comment.
These tests are a good start. I have a couple of suggestions:
- It would be nice if the names of the test functions conveyed more information about what you're testing about the functions. The Django convention is to use long descriptive function names in tests, rather than docstrings, however, there's nothing wrong with adding a docstring if this isn't possible or if you want to be more descriptive. Part 5 of the Django tutorial has good information about this.
- It would be really good to have a test that covers the case for when the MAIL_ALIASES_PATH file isn't found.
| aliaslist.append(alias3) | ||
| aliaslist.append(alias4) | ||
| aliaslist.append(alias5) | ||
| self.assertEqual(filter_by_value(aliaslist, ""), aliaslist) |
There was a problem hiding this comment.
It's good to see you testing for the empty string case.
bufordrat
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Looks great, tests pass on my machine. I don't have any suggestions other than that I agree with the suggestion to have the site for the case where there is no file at MAIL_ALIASES_PATH, and then to also write a test confirming that the site doesn't blow up with an internal server error when that file is missing. With-finalizing in parse_file looks good.
|
Closing the PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #728
Changes in this request