Inverted Groups

[bbusenius]

Fixes #802

Changes in this request

• Fixed bug that was causing Loop groups and subgroups to be inverted.

[vitorgomateus]

for index_child in index_children:
            for inactive_child in inactive_children:
                if inactive_child.is_descendant_of(index_child):
                    inactive_children = inactive_children.not_descendant_of(index_child)

Is this to avoid circular dependency?
It looks good to me, I don't understand the code completely.

[bbusenius]

@vitorgomateus, yes, it's very confusing code (all the groups code is confusing). That part is necessary to filter out the group pages that are children of other GroupIndexPages since other GroupIndexPages can reside under themselves. Without that, it would display all GroupPages in the entire tree. But we only want those that aren't listed under any other GroupInmdexPage. It's not elegant.

[vitorgomateus]

looks good to me

[bufordrat]

Looks great! This type of tree-pruning code is super fiddly/hairy, but it works well on my machine in dev.