Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new mods support #71

Merged
merged 12 commits into from
Oct 28, 2024
Merged

Add new mods support #71

merged 12 commits into from
Oct 28, 2024

Conversation

aydevworks
Copy link
Collaborator

CTP-3561 Lesson source for Marks Transfer
CTP-3562 support H5P marks transfer
CTP-3563 add mod_coursework support
CTP-3660 LTI source for Marks Transfer

@watson8 @aydevworks
CTP-3561 Lesson source for Marks Transfer
86ae492 
CTP-3562 support H5P marks transfer
CTP-3563 add mod_coursework support
CTP-3660 LTI source for Marks Transfer
@aydevworks
Copy link
Collaborator Author

aydevworks commented Oct 10, 2024 •
edited
Loading

I have squashed all new mods commits into one commit to facilitate review and merging.
Deployed on 44-clc. @nbozhkov-ucl

@aydevworks aydevworks requested a review from aspark21 October 10, 2024 08:41
@aydevworks aydevworks self-assigned this Oct 10, 2024
This was referenced Oct 10, 2024
Closed
Closed
Closed
Closed
Closed
@aydevworks aydevworks requested a review from watson8 October 11, 2024 15:41
@watson8
Copy link
Contributor

watson8 commented Oct 14, 2024

@aydevworks I added some commits today to address the comments. Please can you review these?

@aydevworks aydevworks assigned watson8 and unassigned aydevworks Oct 14, 2024
aydevworks
aydevworks commented Oct 14, 2024
View reviewed changes
Copy link
Collaborator Author

@aydevworks aydevworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done review.

classes/assessment/hvp.php Outdated Show resolved Hide resolved
classes/submission/hvp.php Outdated Show resolved Hide resolved
classes/submission/lesson.php Show resolved Hide resolved
classes/submission/lesson.php Show resolved Hide resolved
classes/submission/lti.php Show resolved Hide resolved
@aydevworks
Copy link
Collaborator Author

aydevworks commented Oct 14, 2024 •
edited
Loading

@watson8 Please also fix the issue reported in github action. Thanks!
E.g. https://github.com/ucl-isd/moodle-local_sitsgradepush/actions/runs/11329606732/job/31505508929?pr=71#step:11:72

@watson8
Copy link
Contributor

watson8 commented Oct 15, 2024

@watson8 Please also fix the issue reported in github action. Thanks! E.g. https://github.com/ucl-isd/moodle-local_sitsgradepush/actions/runs/11329606732/job/31505508929?pr=71#step:11:72

Thanks - corrected in commit 1ef64c1

@aydevworks
Copy link
Collaborator Author

aydevworks commented Oct 15, 2024 •
edited
Loading

Looks good to me, deploying to 44-clc @nbozhkov-ucl.

@nbozhkov-ucl
Copy link
Contributor

Have completed testing. All issues identified from first round of testing have been resolved. Results added to https://ucldata.atlassian.net/browse/CTP-4009. Should be good to go into main branch @aspark21 .

@aspark21
Copy link
Collaborator

Code looks good to me, but could we add some automated test coverage for this functionality

@aspark21 aspark21 merged commit 762b58a into main Oct 28, 2024
13 checks passed
@aspark21
Copy link
Collaborator

logged CTP-4026 to follow up on test coverage

@aydevworks aydevworks deleted the CTP-3563-consolidated-all-mods-included-v2 branch October 28, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watson8 watson8 watson8 left review comments

@aspark21 aspark21 aspark21 approved these changes

Assignees

@watson8 watson8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aydevworks @watson8 @nbozhkov-ucl @aspark21