Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MIME types to include application/gzip; Validate prints to stderr instead of stdout #109

Merged
merged 9 commits into from
Nov 23, 2024

Conversation

j2salmingo
Copy link
Contributor

Description

Updates MIME type to include application/gzip since newer magic databases use this instead of application/x-gzip. To resolve the usage in pipelines were stdout is not returned, it will now print the error messages to stderr. Tests have been updated.

In order to test with pipelines, the container creation GitHub Action was also updated.

Closes #107 #108


Checklist

File Commits

  • This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
    Disclosing PHI is a major problem1 - Even a small leak can be costly2.

  • This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.

  • This PR does NOT contain other non-plain text files, such as: compressed files, images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other output files.

  To automatically exclude such files using a .gitignore file, see here for example.

Code Review Best Practices

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Testing

  • I have added unit tests for the new feature(s).

  • I modified the integration test(s) to include the new feature.

  • All new and previously existing tests passed locally and/or on the cluster.

  • The docker image built successfully on the cluster.

Footnotes

  1. UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records

  2. The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records.

  3. Genetic information is considered PHI.
    Forensic assays can identify patients with as few as 21 SNPs

  4. RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity.

Copy link
Collaborator

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! Anything else from @nwiltsie ?

.github/workflows/Docker-build-release.yaml Show resolved Hide resolved
@nwiltsie
Copy link
Member

@j2salmingo Is this good to merge?

@j2salmingo
Copy link
Contributor Author

Yeah, my mistake. I didn't see your approval.

@j2salmingo j2salmingo merged commit eef6af2 into main Nov 23, 2024
6 checks passed
@j2salmingo j2salmingo deleted the jsalmingo-add-mime-types-and-logger branch November 23, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIME type 'application/gzip' missing from FASTQ._get_file_handler
3 participants