Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor list_variants by adding to superclass #27

Open
philsteinberg opened this issue Jul 26, 2022 · 0 comments
Open

Refactor list_variants by adding to superclass #27

philsteinberg opened this issue Jul 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@philsteinberg
Copy link
Contributor

The two list_variants functions do essentially the same thing in this PR and https://github.com/uclahs-cds/tool-SRC-util/pull/22/files. Don't worry about it right now as we want to get the functionalities in first, but I think there is an opportunity to do some refractoring (like moving this function to the superclass and adding a flag for single-sample or multi-sample mode or something). Please open on issue for this either in this repo or in our project repo, thanks!

Originally posted by @lydiayliu in https://github.com/uclahs-cds/tool-SRC-util/pull/23#discussion_r930445465

@lydiayliu lydiayliu added the enhancement New feature or request label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants