Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 602: Warn about key-uniqueness enforcement to types:Dictionary #603

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Issue 602: Warn about key-uniqueness enforcement to types:Dictionary #603

merged 5 commits into from
Jul 26, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented May 7, 2024 •
edited
Loading

This Pull Request will resolve all requirements of Issue #602 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (0a6de6f)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (0210da1)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist
Warn about key-uniqueness enforcement to types:Dictionary
c349b32 
A follow-on patch will regenerate Make-managed files.

References:
* #602

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Regenerate Make-managed files
45d98e9 
References:
* #602

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist added this to the UCO 1.4.0 milestone May 7, 2024
@ajnelson-nist ajnelson-nist linked an issue May 7, 2024 that may be closed by this pull request
UCO's Dictionary class should enforce key uniqueness #602
Closed
17 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request May 7, 2024
Closed
17 tasks
@ajnelson-nist
Fix syntax
c63a636 
No effects were observed on Make-managed files.

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Inline DictionaryEntry nodes
f9d273b 
This manual revision is done to reduce IRI repetitions.

No effects were observed on Make-managed files.

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist mentioned this pull request Jun 4, 2024
Merged
13 tasks
ajnelson-nist added a commit to casework/casework.github.io that referenced this pull request Jun 5, 2024
@ajnelson-nist
Bump unstable pointers
5cfdb68 
Note this tests the implementation as of UCO PR 603.  607 will be tested
in a later patch.

A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#602
* ucoProject/UCO#603

Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist added a commit to casework/casework.github.io that referenced this pull request Jun 5, 2024
@ajnelson-nist
Regenerate Make-managed files
c8ed517 
References:
* ucoProject/UCO#602
* ucoProject/UCO#603

Signed-off-by: Alex Nelson <[email protected]>
@plbt5 plbt5 merged commit 06392e9 into develop Jul 26, 2024
1 check passed
@ajnelson-nist ajnelson-nist deleted the Feature-Issue-602 branch October 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 1.4.0
Development

Successfully merging this pull request may close these issues.

UCO's Dictionary class should enforce key uniqueness
2 participants
@ajnelson-nist @plbt5