Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 624: Add cpeid to DeviceFacet #625

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Issue 624: Add cpeid to DeviceFacet #625

merged 4 commits into from
Nov 22, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Aug 2, 2024 •
edited
Loading

This Pull Request resolves all requirements of Issue #624 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (16727e9)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (4a6c630)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist
Add cpeid to DeviceFacet
dd8abaa 
No effects were observed on Make-managed files.

References:
* #624

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist added this to the UCO 1.4.0 milestone Aug 2, 2024
@ajnelson-nist ajnelson-nist linked an issue Aug 2, 2024 that may be closed by this pull request
Devices should have CPEs associable #624
Open
15 tasks
@ajnelson-nist
Warn of coming constraints on observable:cpeid
0377992 
A follow-on patch will regenerate Make-managed files.

References:
* #626

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist mentioned this pull request Aug 2, 2024
Draft
@ajnelson-nist ajnelson-nist mentioned this pull request Nov 22, 2024
Open
15 tasks
@ajnelson-nist
Revert "Warn of coming constraints on observable:cpeid"
50ce7ee 
This reverts commit 0377992.

The effects of Issue 626 are not ready for Issue 624.  This patch's
effects will move into 626's development.

References:
* #626

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Merge branch 'develop' into Feature-Issue-624
9debc59
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review November 22, 2024 14:52
@ajnelson-nist ajnelson-nist requested a review from a team November 22, 2024 14:52
@plbt5 plbt5 merged commit cc26145 into develop Nov 22, 2024
1 check passed
@plbt5 plbt5 deleted the Feature-Issue-624 branch November 22, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 1.4.0
Development

Successfully merging this pull request may close these issues.

Devices should have CPEs associable
2 participants
@ajnelson-nist @plbt5