Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for scanner output #239

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

nimakarimipour
Copy link
Member

@nimakarimipour nimakarimipour commented Aug 8, 2024

This PR introduces a check on the AnnotatorScanner output and notifies the user if AnnotatorScanner is incorrectly configured or has crashed. Before this PR, the Annotator would simply crash with a 'nonnull_elements.tsv not found' error (generated by AnnotatorScanner), which did not clearly indicate the underlying issue.

This PR is also related to #238.

@nimakarimipour nimakarimipour self-assigned this Aug 9, 2024
@nimakarimipour nimakarimipour added the enhancement New feature or request label Aug 9, 2024
@nimakarimipour nimakarimipour requested a review from msridhar August 9, 2024 00:12
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think addressing #237 at some point would also be helpful

@nimakarimipour nimakarimipour merged commit f4e63f6 into master Aug 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants