Error reporting final merge #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviaweng
commented
Jun 1, 2022
•
oliviaweng
commented
- Prettified lambda function, lists, for-loop, and destructuring type check error messages
- Fixed associated merge conflicts with these features
- Added extra tests to confirm our prettified error messages are thrown correctly
* Assigning a mklambda expression to the wrong Callable type was correctly caught at compile time, but the type error message only communicated that "callable" type is not assignable to "callable" type, which is confusing. * We now update the type error message to include the callable param and return types, e.g., "callable[[int], bool]", for a more informative type error message.
* Fixed list type check error API issues * Added a number of tests to ensure type check error API is now accessed correctly for lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.