Skip to content

Commit

Permalink
Test detect failure, bump spec.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
dafeliton committed Mar 5, 2024
1 parent 334c9b5 commit f4bc01d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
3 changes: 2 additions & 1 deletion images/datascience-notebook/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ ARG PANDAS_VERSION=2.2.1 STATSMODELS_VERSION=0.14.1

# Install essential+datascience pip packages
## mistune added for nbgrader issues
# TODO DEBUG: Remove nltk_data, this is to test docker exception handling.
RUN pip install pillow typing-extensions tzlocal appdirs gputil mock pytest \
nltk statsmodels==$STATSMODELS_VERSION pandas==$PANDAS_VERSION 'mistune>=2' --upgrade && \
nltk nltk_data statsmodels==$STATSMODELS_VERSION pandas==$PANDAS_VERSION 'mistune>=2' --upgrade && \
pip install dpkt nose datascience && \
python -c 'import matplotlib.pyplot' && \
fix-permissions $CONDA_DIR && \
Expand Down
2 changes: 1 addition & 1 deletion images/spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ images:
#prepull: false #-- uncomment to disable prepulling behavior for scipy-ml. gives you space on machine in exchange for build time.

tag:
prefix: "2023.4"
prefix: "2024.3"

all_info_cmds:
PY_VER:
Expand Down
9 changes: 6 additions & 3 deletions scripts/docker_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,16 @@ def build(node: Node) -> Tuple[bool, str]:
return True, report

except docker_client.errors.BuildError as build_e:
logger.error(f"Error during build of {node.image_name},\n {build_e}")
logger.error(f"Docker returned build error during build of {node.image_name},\n {build_e}")
return False, report
except docker_client.errors.APIError as api_e:
logger.error(f"Server returns error during build of {node.image_name},\n {api_e}")
logger.error(f"Docker returned API error during build of {node.image_name},\n {api_e}")
return False, report
except docker_client.errors.DockerException as docker_e:
logger.error(f"Docker returned generic error during build of {node.image_name},\n {docker_e}")
return False, report
except Exception as e:
logger.error("Unrecognized error; \n" + str(e))
logger.error("Unrecognized exception; \n" + str(e))
return False, report

finally:
Expand Down

0 comments on commit f4bc01d

Please sign in to comment.