Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions integration. #8

Merged
merged 46 commits into from
May 31, 2024
Merged

GH Actions integration. #8

merged 46 commits into from
May 31, 2024

Conversation

stopfstedt
Copy link
Member

@stopfstedt stopfstedt commented May 23, 2024 •
edited
Loading

fixes #5
fixes #6
fixes #7

@stopfstedt stopfstedt marked this pull request as draft May 23, 2024 22:29
stopfstedt added 13 commits May 24, 2024 07:53
@stopfstedt
corrects code linting errors in email.php
e513530
@stopfstedt
corrects code linting errors in language files.
fdfa4f5
@stopfstedt
Corrects PHP linter errors in version.php
ee8bdb4
@stopfstedt
corrects PHP linting errors in alternate.php
8602a07
@stopfstedt
corrects PHP linting erros in alt_lib.php
8b08f0b
@stopfstedt
Corrects PHP linter errors in alt_form.php
a0a439d
@stopfstedt
aligns function visibility scope of definition() with overwritten par…
a62afff 
…ent method.
@stopfstedt
Corrects PHP linter errors in signature_form.php
04d4941 
realigns visibility of definition() method with its overridden
parent method while at it.
@stopfstedt
Corrects PHP linter errors in signature.php
d0b55a5
@stopfstedt
Corrects PHP linting errors in block_quickmail.php
890d321
@stopfstedt
Corrects PHP linter errors in email_form.php
6ca686b
@stopfstedt
moves login check back where it was.
22b8a8a 
didn't have to move it up after all.
@stopfstedt
Cleans up PHP linter errors in emaillog.php
75643aa
@stopfstedt stopfstedt force-pushed the gh_actions branch 2 times, most recently from fe92be7 to 061b0ec Compare May 24, 2024 22:17
stopfstedt added 15 commits May 28, 2024 11:18
@stopfstedt
replace deprecrated constant with its value.
6b1163f
@stopfstedt
Corrects PHP linter errors in classes/event/alternate_email_added.php
53b7d46
@stopfstedt
Corrects PHP linter errors in backup/moodle2/restore_quickmail_stepsl…
1d04625 
…ib.php
@stopfstedt
Corrects PHP linter errors in backup/moodle2/backup_quickmail_block_t…
3f6f3cd 
…ask.class.php
@stopfstedt
corrects param annotation in doc block.
782f155
@stopfstedt
corrects docblock description for backup task.
a7bb51d
@stopfstedt
Corrects PHP linter errors in backup/moodle2/backup_stepslib.php
1ef648f
@stopfstedt
Corrects PHP linter errors in quickmail/backup/restore_quickmail_bloc…
a7ee2c4 
…k_task.class.php
@stopfstedt
fix up any remaining PHPCS linter errors.
f5d839c
@stopfstedt
correct linter warnings by alphabetically sorting lang strings by the…
adc6416 
…ir keys, rm duplicates.
@stopfstedt
fix up docblock on method that phpdoc was nagging about.
cf162f5
@stopfstedt
adds missing tags to behat feature.
013271a
@stopfstedt
corrects failing savepoints checks.
3b34168 
consolidate duplicate steps and always pass TRUE instead of a variable
as first arg to upgrade_block_savepoint - anything else will throw off
the linter.
@stopfstedt
applies code standard fixes to behat test features.
7631b4e
@stopfstedt
cleans up linter errors in stylesheet.
0ca5a0e 
- fix indentation
- rm empty rules
- rm invalid position style declaration
@stopfstedt stopfstedt force-pushed the gh_actions branch 2 times, most recently from 50e18c5 to 4466c1f Compare May 30, 2024 17:54
stopfstedt added 5 commits May 30, 2024 13:53
@stopfstedt
fix up variables names.
153834b 
the auto-fixer didn't update the var names when referenced, so we have
to do this manually now.
@stopfstedt
fixes goobered up lang string.
d23b47f
@stopfstedt
wip: fixes up behat tests.
1cd13cf
@stopfstedt
suppress the behat scenarios in the ferpa feature from running.
e02799f 
kneejerking to the fact that this will take a long time to repair these
tests.
let's keep 'em on file in the mean time but pull them out of the test
runner by renaming the file (there's no default "skip this" tag or the
likes, so this is the easiest way to pull these out of any test run).
@stopfstedt
rm kruft
5876d90 
leftover from a test generator implementation that's been gone long
since,  you can find the rest of it in the git history if you're
interested.
@stopfstedt stopfstedt marked this pull request as ready for review May 31, 2024 04:11
@stopfstedt stopfstedt merged commit 84e9659 into UCSFCLE_403_DEVEL May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stopfstedt